From: Simon 'corecode' Schubert <corecode@fs.ei.tum.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: Jason Sewall <jasonsewall@gmail.com>,
git@vger.kernel.org, raa.lkml@gmail.com
Subject: Re: [PATCH] Add a 1-second sleep to git-cvsexportcommit test
Date: Mon, 23 Jul 2007 09:55:32 +0200 [thread overview]
Message-ID: <46A45EF4.9090305@fs.ei.tum.de> (raw)
In-Reply-To: <7vd4yjoi2w.fsf@assigned-by-dhcp.cox.net>
Junio C Hamano wrote:
> It may be that we may want to fix this inside cvsexportcommit
> itself, instead of working it around in the tests. If somebody
> tries to push more than one commit from git using two
> cvsexportcommit in a row, he would need to make sure that the
> second run happens one or more seconds after the first run,
> otherwise he will see the exact corruption in real life.
Ah, now I see the problem. The timestamp in the CVS/Entries is the same (because it only has second granularity), so cvs commit won't consider it as changed.
That's the reason why CVS usually waits until the second turns after a "update" (obviously not after a "commit"). So we could either turn back the timestamp in the Entries file (ugly) or simply wait until the second turns. Given the overall cvs performance, this won't be a big issue, I guess.
cheers
simon
--
Serve - BSD +++ RENT this banner advert +++ ASCII Ribbon /"\
Work - Mac +++ space for low €€€ NOW!1 +++ Campaign \ /
Party Enjoy Relax | http://dragonflybsd.org Against HTML \
Dude 2c 2 the max ! http://golden-apple.biz Mail + News / \
next prev parent reply other threads:[~2007-07-23 7:55 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-22 19:41 Test #7 in t9200-git-cvsexportcommit fails Jason Sewall
2007-07-22 20:21 ` Alex Riesen
2007-07-22 20:49 ` Jason Sewall
2007-07-22 21:42 ` Alex Riesen
2007-07-22 22:19 ` Junio C Hamano
2007-07-23 3:59 ` [PATCH] Add a 1-second sleep to git-cvsexportcommit test Jason Sewall
2007-07-23 4:32 ` Junio C Hamano
2007-07-23 7:55 ` Simon 'corecode' Schubert [this message]
2007-07-24 0:23 ` Robin Rosenberg
2007-07-24 8:11 ` Simon 'corecode' Schubert
2007-07-24 8:33 ` Robin Rosenberg
2007-07-24 8:38 ` Simon 'corecode' Schubert
2007-07-24 9:34 ` Robin Rosenberg
2007-07-24 10:14 ` Junio C Hamano
2007-07-24 12:57 ` Robin Rosenberg
2007-07-24 15:31 ` Jason Sewall
2007-07-24 19:02 ` Linus Torvalds
2007-07-24 22:56 ` Robin Rosenberg
2007-07-24 23:19 ` Linus Torvalds
2007-07-25 7:35 ` Andy Parkins
2007-07-25 7:43 ` Marius Storm-Olsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46A45EF4.9090305@fs.ei.tum.de \
--to=corecode@fs.ei.tum.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jasonsewall@gmail.com \
--cc=raa.lkml@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).