git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "René Scharfe" <rene.scharfe@lsrfire.ath.cx>
To: Mark Levedahl <mlevedahl@gmail.com>
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>,
	Junio C Hamano <junkio@cox.net>,
	Git Mailing List <git@vger.kernel.org>
Subject: Re: rc4 - make quick-install-doc is broken
Date: Sat, 04 Aug 2007 22:19:05 +0200	[thread overview]
Message-ID: <46B4DF39.2070506@lsrfire.ath.cx> (raw)
In-Reply-To: <46B4A2B0.9080208@gmail.com>

Mark Levedahl schrieb:
> git>git bisect good
> 6490a3383f1d0d96c122069e510ef1af1d019fbb is first bad commit

I've started a bisect run myself and ended up at a different commit,
viz. e90fdc39b6903502192b2dd11e5503cea721a1ad ("Clean up work-tree
handling").  Hmm.  I guess this candidate has a greater chance of
actually being the culprit than yours. ;-)

I can't offer a fix, but I think I've captured install-doc-quick.sh's
problem in a test script (see below).  It fails with e90fdc3 (and
master) but succeeds with e90fdc3^.

Apparently checkout-index (and ls-files, but this is not used by the
install script) can now be confused by running it from inside an
untracked directory.

Johannes, does this help you in finding out what's going on here?

René


diff --git a/dev/null b/t/t1502-untracked.sh
new file mode 100755
index 0000000..3fbdb02
--- /dev/null
+++ b/t/t1502-untracked.sh
@@ -0,0 +1,36 @@
+#!/bin/sh
+
+test_description='accessing the index from an untracked directory'
+. ./test-lib.sh
+
+pwd=$(pwd)
+GIT_DIR=$pwd/.git
+export GIT_DIR
+
+test_expect_success 'setup' '
+	git init &&
+	echo some file content >some_file &&
+	git add some_file &&
+	git commit -m "added a file" some_file &&
+	mkdir untracked
+'
+
+test_expect_success 'test read-tree from an untracked directory' '
+	(                GIT_INDEX_FILE=$pwd/idx-a git read-tree HEAD) &&
+	(cd untracked && GIT_INDEX_FILE=$pwd/idx-b git read-tree HEAD) &&
+	git diff --binary idx-a idx-b
+'
+
+test_expect_success 'test checkout-index from an untracked directory' '
+	(                git checkout-index -a --prefix=$pwd/a/) &&
+	(cd untracked && git checkout-index -a --prefix=$pwd/b/) &&
+	git diff a/ b/
+'
+
+test_expect_success 'test ls-files from an untracked directory' '
+	(                git ls-files) >ls-files-a &&
+	(cd untracked && git ls-files) >ls-files-b &&
+	git diff ls-files-a ls-files-b
+'
+
+test_done

  parent reply	other threads:[~2007-08-04 20:19 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-04 15:07 rc4 - make quick-install-doc is broken Mark Levedahl
2007-08-04 15:38 ` Johannes Schindelin
2007-08-04 16:00   ` Mark Levedahl
2007-08-04 16:04     ` Johannes Schindelin
2007-08-04 16:14       ` Mark Levedahl
2007-08-04 16:21         ` Johannes Schindelin
2007-08-04 17:56           ` Mark Levedahl
2007-08-04 21:32             ` [PATCH] Fix quick-install-doc Johannes Schindelin
2007-08-04 22:09               ` René Scharfe
2007-08-05  7:07                 ` [PATCH] Fix install-doc-quick target Junio C Hamano
2007-08-05 13:12                   ` Johannes Schindelin
2007-08-05 17:54                     ` Junio C Hamano
2007-08-05 18:10                       ` Johannes Schindelin
2007-08-05 14:44                   ` Johannes Schindelin
2007-08-06 22:43                   ` [PATCH] (Really) " Mark Levedahl
2007-08-06 22:50                     ` Johannes Schindelin
2007-08-06 23:07                       ` Junio C Hamano
2007-08-06 23:38                         ` Mark Levedahl
2007-08-06 23:43                           ` Johannes Schindelin
2007-08-06 23:49                             ` Mark Levedahl
2007-08-07  1:28                           ` Junio C Hamano
2007-08-07  1:55                             ` Mark Levedahl
2007-08-07  3:53                               ` Junio C Hamano
2007-08-07 13:55                                 ` René Scharfe
2007-08-07 14:08                                   ` Johannes Schindelin
2007-08-04 16:08     ` rc4 - make quick-install-doc is broken Mark Levedahl
2007-08-04 16:16       ` Johannes Schindelin
2007-08-04 16:27         ` Mark Levedahl
2007-08-04 20:19     ` René Scharfe [this message]
2007-08-04 20:21       ` Johannes Schindelin
2007-08-04 20:45       ` Mark Levedahl
2007-08-04 21:33       ` Johannes Schindelin
2007-08-04 22:09         ` René Scharfe
2007-08-04 22:25           ` Johannes Schindelin
2007-08-04 22:37           ` Johannes Schindelin
2007-08-04 23:03             ` René Scharfe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46B4DF39.2070506@lsrfire.ath.cx \
    --to=rene.scharfe@lsrfire.ath.cx \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=junkio@cox.net \
    --cc=mlevedahl@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).