git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Steven Grimm <koreth@midwinter.com>
To: David Kastrup <dak@gnu.org>
Cc: "Wincent Colaiuta" <win@wincent.com>,
	"René Scharfe" <rene.scharfe@lsrfire.ath.cx>,
	git@vger.kernel.org
Subject: Re: --exit-code (and --quiet) broken in git-diff?
Date: Sun, 12 Aug 2007 21:02:40 +0800	[thread overview]
Message-ID: <46BF04F0.5020304@midwinter.com> (raw)
In-Reply-To: <85643lq99h.fsf@lola.goethe.zz>

David Kastrup wrote:
> I think I would call that a mistake.  However, I don't see that fixing
> it would actually be useful: if a pager gets called, this means that
> git-diff might die with SIGPIPE (when the user quits the pager), and
> that in turn has pretty much no meaning.  So one really needs to
> redirect the output, anyway.
>   

It does sort of make one wonder, though, if there's much point ever 
launching a pager when git-diff is run with --quiet -- it will never 
produce any output to page, so running a pager is guaranteed to always 
be a waste of cycles.

Unfortunately the pager is launched before the option processing code 
knows whether --quiet is being used or not; I'm not sure it's worth 
refactoring the pager launch code just to handle this one special case. 
(Or are there other cases where programs would want to be able to 
control the use of the pager?)

-Steve

  reply	other threads:[~2007-08-12 13:02 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-11 23:12 --exit-code (and --quiet) broken in git-diff? Wincent Colaiuta
2007-08-12  9:40 ` René Scharfe
2007-08-12 11:24   ` Wincent Colaiuta
2007-08-12 11:31     ` David Kastrup
2007-08-12 13:02       ` Steven Grimm [this message]
2007-08-12 13:29         ` David Kastrup
2007-08-12 16:57         ` Wincent Colaiuta
2007-08-12 11:33   ` Steffen Prohaska
2007-08-12 17:46 ` [PATCH] diff: don't run pager if user asked for a diff style exit code René Scharfe
2007-08-13  9:57   ` Wincent Colaiuta
2007-08-13 10:23     ` David Kastrup
2007-08-13 23:42   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46BF04F0.5020304@midwinter.com \
    --to=koreth@midwinter.com \
    --cc=dak@gnu.org \
    --cc=git@vger.kernel.org \
    --cc=rene.scharfe@lsrfire.ath.cx \
    --cc=win@wincent.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).