From: Johannes Sixt <J.Sixt@eudaptics.com>
To: git@vger.kernel.org
Subject: Re: [PATCH] Make git-prune submodule aware (and fix a SEGFAULT in the process)
Date: Fri, 17 Aug 2007 11:14:44 +0200 [thread overview]
Message-ID: <46C56704.6D917A53@eudaptics.com> (raw)
In-Reply-To: 200708170939.47214.andyparkins@gmail.com
Andy Parkins wrote:
> Could any of the guru's give me a guide to upload-pack.c? I assume the
> problem is going to be the same as it was for git-prune, the hash for the
> gitlink object in the tree is being assumed to be an object in the ODB;
> which isn't the case with gitlink entries. Where would that be happening
> in git-upload-pack? The fix is going to be..
>
> if( S_ISGITLINK(mode))
> continue;
>
> But I've got no idea where to put it :-)
Most likely in list-objects.c:traverse_commit_list(), which is called
from somewhere in upload-pack.c.
-- Hannes
next prev parent reply other threads:[~2007-08-17 9:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-02 12:56 [PATCH] Make git-prune submodule aware (and fix a SEGFAULT in the process) Andy Parkins
2007-07-02 23:11 ` Junio C Hamano
2007-08-17 8:39 ` Andy Parkins
2007-08-17 9:14 ` Johannes Sixt [this message]
2007-08-17 16:56 ` Linus Torvalds
2007-08-17 23:48 ` Junio C Hamano
2007-08-20 8:39 ` Andy Parkins
2007-08-18 9:54 ` [PATCH] Make thin-pack generation subproject aware Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46C56704.6D917A53@eudaptics.com \
--to=j.sixt@eudaptics.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).