git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Steven Grimm <koreth@midwinter.com>
To: Evan Phoenix <evan@fallingsnow.net>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH] A more sensible error message why 'git rebase --continue' failed
Date: Mon, 20 Aug 2007 21:59:02 +0800	[thread overview]
Message-ID: <46C99E26.2020009@midwinter.com> (raw)
In-Reply-To: <2D8BF484-7990-4DDC-9E52-69143D4BA413@fallingsnow.net>

Evan Phoenix wrote:
> How about something like
>
> "Please verify all merge conflicts in all modified files, then run
> 'git add' to resolve them."

Since we're nitpicking language here... "git add" doesn't resolve 
anything. *You* resolve the conflicts (by editing the file and removing 
the conflict markers and editing the code, by running git mergetool, 
etc.) then you run "git add" to tell git that you're done resolving.

If I literally followed the above, I would run "less" on a file, say, 
"Yep, git flagged all the merge conflicts correctly," then run "git add" 
figuring it would pop me into some kind of conflict resolution UI. 
Actually it's worse than that -- the above implies that all modified 
files will have merge conflicts, which is certainly not true in many cases.

How about:

"Please resolve all merge conflicts, then run 'git add' to tell git you've
finished resolving each file."

-Steve

  reply	other threads:[~2007-08-20 13:59 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-20  1:13 [PATCH] A more sensible error message why 'git rebase --continue' failed Evan Phoenix
2007-08-20  6:25 ` Junio C Hamano
2007-08-20  7:10   ` Evan Phoenix
2007-08-20 13:59     ` Steven Grimm [this message]
2007-08-20  9:35 ` Johannes Sixt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46C99E26.2020009@midwinter.com \
    --to=koreth@midwinter.com \
    --cc=evan@fallingsnow.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).