git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Quy Tonthat <qtonthat@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Fix break in git-rev-list.txt
Date: Thu, 23 Aug 2007 00:37:55 +1000	[thread overview]
Message-ID: <46CC4A43.9050305@gmail.com> (raw)
In-Reply-To: <7vbqczkhvb.fsf@gitster.siamese.dyndns.org>

Junio C Hamano wrote:
> 
> Hmph.  Interesting.  The text around this is:
> 
> 	-g, --wark-reflogs::
> 
>         	Indented first paragraph...
> 	+
>         With '\--pretty' fromat ... second paragraph ...
> 	prefixed with this information on the same line.
> 	+
>         Cannot be combined with --reverse.
> 
> And its formatted form looks like either (without your patch):
> 
> 	<listitem>
>         <simpara>
>         	Indented first paragraph...
> 	With <emphasis>--pretty</emphasis> format ...
> 	</simpara>
>         <simpara>Cannot be combined with --reverse.</simpara>
> 
>         </listitem>	
> 
> or (with):
> 
> 	<listitem>
>         <simpara>
>         	Indented first paragraph...
> 	With <emphasis>--pretty</emphasis> format ...
> 	Cannot be combined with --reverse.
> 	</simpara>
> 
>         </listitem>	
> 

Well, it goes differently on my system here (asciidoc 8.1.0), as shown
in the diff bellow:

	--- git-rev-list.xml.bad	2007-08-23 00:08:58.000000000 +1000
	+++ git-rev-list.xml.good	2007-08-23 00:10:20.000000000 +1000
	@@ -509,16 +509,15 @@
	         When this option is used you cannot specify commits to
	         exclude (that is, <emphasis>&#94;commit</emphasis>, <emphasis>commit1..commit2</emphasis>,
	         nor <emphasis>commit1&#8230;commit2</emphasis> notations cannot be used).
	-<literal>
	 With <emphasis>--pretty</emphasis> format other than oneline (for obvious reasons),
	 this causes the output to have two extra lines of information

	 taken from the reflog.  By default, <emphasis>commit@{Nth}</emphasis> notation is
	 used in the output.  When the starting commit is specified as

	 instead.  Under <emphasis>--pretty=oneline</emphasis>, the commit message is

	 prefixed with this information on the same line.

	-</literal>

	-Cannot be combined with --reverse.

	 </simpara>

	+<simpara>Cannot be combined with --reverse.</simpara>

	+

	 </listitem>

	 </varlistentry>

	 <varlistentry>


Note the extra <literal></literal> which what xmlto has problems with as
in its error messages

/work/devel/git/git.git/Documentation/git-rev-list.xml:512: element literal: validity error : Element emphasis is not declared in literal list of possible children

I'll have a look at asciidoc as soon as I have some time.

Quy

  parent reply	other threads:[~2007-08-22 14:38 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-22  8:18 [PATCH] Fix break in git-rev-list.txt Quy Tonthat
2007-08-22 10:01 ` Junio C Hamano
2007-08-22 10:58   ` David Kastrup
2007-08-22 14:37   ` Quy Tonthat [this message]
2007-08-22 15:29   ` Quy Tonthat
2007-08-22 16:45   ` Quy Tonthat

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46CC4A43.9050305@gmail.com \
    --to=qtonthat@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).