git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "René Scharfe" <rene.scharfe@lsrfire.ath.cx>
To: Miklos Vajna <vmiklos@frugalware.org>
Cc: git@vger.kernel.org
Subject: Re: testsuite problems
Date: Tue, 18 Sep 2007 16:57:33 +0200	[thread overview]
Message-ID: <46EFE75D.7000805@lsrfire.ath.cx> (raw)
In-Reply-To: <20070917220408.GG19019@genesis.frugalware.org>

Miklos Vajna schrieb:
> On Mon, Sep 17, 2007 at 11:50:32PM +0200, René Scharfe <rene.scharfe@lsrfire.ath.cx> wrote:
>> The failing tests check ZIP file creation, not tar file creation.
>> Perhaps your unzip command works a bit differently from Info-ZIP's?
> 
> $ zip -v
> Copyright (c) 1990-2006 Info-ZIP - Type 'zip "-L"' for software license.
> This is Zip 2.32 (June 19th 2006), by Info-ZIP.
> 
> should this version be ok?

Info-ZIP zip and unzip are two different programs, each with their
own version numbers.

>> Also, what is the difference between t/trash/a and t/trash/d/a after
>> running the test script (that's what test 21 is comparing)?
> 
> $ diff -Naur t/trash/a t/trash/d/a
> diff -Naur t/trash/a/l1 t/trash/d/a/l1
> --- t/trash/a/l1        2007-09-17 23:10:03.000000000 +0200
> +++ t/trash/d/a/l1      2007-09-17 23:10:03.000000000 +0200
> @@ -1 +1 @@
> -simple textfile
> +a
> \ No newline at end of file

Ah!  l1 is a symlink to a.  The target of a symlink is stored as file
content in a ZIP archive and marked with a special flag.  An unzipper
that doesn't understand this flag would create a file containing the
link target's name instead of a symlink pointing to the target.

The unzip on my system says:

  $ unzip -v
  UnZip 5.52 of 28 February 2005, by Ubuntu. Original by Info-ZIP.

  Latest sources and executables are at  ftp://ftp.info-zip.org/pub/infozip/ ;
  see ftp://ftp.info-zip.org/pub/infozip/UnZip.html for other sites.

  Compiled with gcc 4.1.2 (Ubuntu 4.1.2-0ubuntu4) for Unix (Linux ELF) on Mar 31 2007.

  UnZip special compilation options:
          ACORN_FTYPE_NFS
          COPYRIGHT_CLEAN (PKZIP 0.9x unreducing method not supported)
          SET_DIR_ATTRIB
          TIMESTAMP
          USE_EF_UT_TIME
          USE_UNSHRINK (PKZIP/Zip 1.x unshrinking method supported)
          USE_DEFLATE64 (PKZIP 4.x Deflate64(tm) supported)
          VMS_TEXT_CONV
          WILD_STOP_AT_DIR
          [decryption, version 2.9 of 05 May 2000]

I suspect you need SET_DIR_ATTRIB in order to extract symlinks.

René

  parent reply	other threads:[~2007-09-18 14:57 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-17 21:17 testsuite problems Miklos Vajna
2007-09-17 21:41 ` Pierre Habouzit
2007-09-17 21:50 ` René Scharfe
2007-09-17 22:04   ` Miklos Vajna
2007-09-17 22:40     ` Johannes Schindelin
2007-09-17 22:48       ` Miklos Vajna
2007-09-17 22:50         ` Johannes Schindelin
2007-09-18 14:57     ` René Scharfe [this message]
2007-09-18 15:52       ` Miklos Vajna
2007-09-18 17:05         ` René Scharfe
2007-09-18 19:35           ` Miklos Vajna

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46EFE75D.7000805@lsrfire.ath.cx \
    --to=rene.scharfe@lsrfire.ath.cx \
    --cc=git@vger.kernel.org \
    --cc=vmiklos@frugalware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).