From: Martin Langhoff <martin.langhoff@gmail.com>
To: Matthias Urlichs <smurf@smurf.noris.de>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] cg-diff fixed to work with BSD xargs
Date: Wed, 21 Sep 2005 22:56:12 +1200 [thread overview]
Message-ID: <46a038f905092103561eac26a6@mail.gmail.com> (raw)
In-Reply-To: <pan.2005.09.21.07.33.14.533314@smurf.noris.de>
On 9/21/05, Matthias Urlichs <smurf@smurf.noris.de> wrote:
> I don't know what drugs your shell was on when you tested this (assuming
> that you did ;-) but this patch is wrong -- your test always succeeds,
> due to the vagaries of test / [ ] semantics.
I've submitted test-time and commit-time urine tests to the relevant
authorities. Both my shell and me are clean of forbidden substances
;-)
As Petr notes, the code is testing for a variable that we generated,
not random user input. Yes, perhaps we should test $TMPDIR for sanity,
but I think it's a bit overparanoid.
cheers,
martin
prev parent reply other threads:[~2005-09-21 10:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-20 4:15 cg-diff still broken on some BSDs Martin Langhoff
2005-08-30 10:00 ` [PATCH] cg-diff fixed to work with BSD xargs Martin Langhoff
2005-08-30 14:20 ` Junio C Hamano
2005-09-20 19:39 ` Petr Baudis
2005-09-20 19:36 ` Petr Baudis
2005-09-21 7:33 ` Matthias Urlichs
2005-09-21 8:15 ` Petr Baudis
2005-09-21 10:06 ` Matthias Urlichs
2005-09-21 10:11 ` Petr Baudis
2005-09-21 10:54 ` Matthias Urlichs
2005-09-21 10:56 ` Martin Langhoff [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46a038f905092103561eac26a6@mail.gmail.com \
--to=martin.langhoff@gmail.com \
--cc=git@vger.kernel.org \
--cc=smurf@smurf.noris.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).