From: "Martin Langhoff" <martin.langhoff@gmail.com>
To: "Martin Langhoff" <martin.langhoff@gmail.com>,
"Junio C Hamano" <junkio@cox.net>,
"Matthias Urlichs" <smurf@smurf.noris.de>,
git@vger.kernel.org
Subject: Re: [PATCH 2/2] cvsimport: cleanup commit function
Date: Tue, 23 May 2006 20:13:10 +1200 [thread overview]
Message-ID: <46a038f90605230113x2f6b0e4bq5a2ea97308b495e0@mail.gmail.com> (raw)
In-Reply-To: <20060523070007.GC6180@coredump.intra.peff.net>
Jeff,
good stuff -- aiming at exactly the things that had been nagging me.
Some minor notes on top of what junio's mentioned...
> + die "unable to open $f: $!" unless $! == POSIX::ENOENT;
> + return undef;
Heh. Is that the return of the living dead?
> +sub update_index (\@\@) {
> + my $old = shift;
> + my $new = shift;
Would it not make more sense to just pass them as plain parameters?
> + print "Committed patch $patchset ($branch $commit_date)\n" if
Given that we have that -- should we remember it and avoid re-reading
the headref from disk? A %seenheads cache would save us 99.9% of the
hassle.
In related news, I've dealt with file reads from the socket being
memorybound. Should merge ok.
cheers,
martin
next prev parent reply other threads:[~2006-05-23 8:13 UTC|newest]
Thread overview: 83+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-20 17:26 irc usage Linus Torvalds
2006-05-20 17:50 ` Junio C Hamano
2006-05-20 18:52 ` Jakub Narebski
2006-05-20 20:39 ` Yann Dirson
2006-05-20 22:18 ` Donnie Berkholz
2006-05-20 22:45 ` Linus Torvalds
2006-05-20 23:12 ` Donnie Berkholz
2006-05-21 19:24 ` Linus Torvalds
2006-05-22 3:59 ` Linus Torvalds
2006-05-22 4:19 ` Donnie Berkholz
2006-05-22 4:50 ` Linus Torvalds
2006-05-22 5:04 ` Martin Langhoff
2006-05-22 5:21 ` Donnie Berkholz
2006-05-22 7:42 ` Martin Langhoff
2006-05-22 9:13 ` Linus Torvalds
2006-05-22 12:54 ` Martin Langhoff
2006-05-22 17:27 ` Linus Torvalds
2006-05-22 17:51 ` Jakub Narebski
2006-05-22 18:03 ` Linus Torvalds
2006-05-22 19:03 ` Matthias Lederhofer
2006-05-22 19:09 ` Junio C Hamano
2006-05-23 20:19 ` Jakub Narebski
2006-05-22 19:46 ` Martin Langhoff
2006-05-22 19:09 ` Donnie Berkholz
2006-05-22 19:38 ` Linus Torvalds
2006-05-22 19:49 ` Donnie Berkholz
2006-05-22 20:20 ` Linus Torvalds
2006-05-22 21:48 ` Donnie Berkholz
2006-05-29 21:54 ` Donnie Berkholz
2006-05-29 22:21 ` Martin Langhoff
2006-05-29 22:32 ` Donnie Berkholz
2006-05-30 0:19 ` Martin Langhoff
2006-05-30 5:31 ` Donnie Berkholz
2006-05-30 6:01 ` Martin Langhoff
2006-05-30 0:43 ` Linus Torvalds
2006-05-30 22:31 ` Martin Langhoff
2006-05-30 23:07 ` Linus Torvalds
2006-05-31 1:04 ` Martin Langhoff
2006-05-31 2:49 ` Donnie Berkholz
2006-05-31 6:05 ` Martin Langhoff
2006-05-31 13:54 ` Alec Warner
2006-05-31 22:03 ` Martin Langhoff
2006-06-01 1:42 ` Alec Warner
2006-06-01 7:47 ` Martin Langhoff
2006-06-05 0:33 ` Alec Warner
2006-06-05 2:06 ` Martin Langhoff
2006-06-05 2:36 ` Alec Warner
2006-06-05 3:49 ` Martin Langhoff
[not found] ` <20060605120743.566fb85f.seanlkml@sympatico.ca>
2006-06-05 16:07 ` Sean
2006-05-22 19:41 ` Martin Langhoff
2006-05-22 20:11 ` Linus Torvalds
2006-05-22 20:33 ` Linus Torvalds
2006-05-22 21:41 ` Matthias Urlichs
2006-05-22 22:18 ` Linus Torvalds
2006-05-22 23:23 ` Martin Langhoff
2006-05-22 23:29 ` Martin Langhoff
2006-05-22 23:33 ` Linus Torvalds
2006-05-22 22:39 ` Junio C Hamano
2006-05-22 23:15 ` Martin Langhoff
2006-05-23 6:52 ` Jeff King
2006-05-23 6:58 ` Jeff King
2006-05-23 7:01 ` [PATCH 1/2] cvsimport: use git-update-index --index-info Jeff King
2006-05-23 7:00 ` [PATCH 2/2] cvsimport: cleanup commit function Jeff King
[not found] ` <7v4pzh6wtr.fsf@assigned-by-dhcp.cox.net>
2006-05-23 7:13 ` Jeff King
2006-05-23 7:27 ` [PATCH 1/2] cvsimport: use git-update-index --index-info Jeff King
2006-05-23 8:13 ` Martin Langhoff [this message]
2006-05-23 8:24 ` [PATCH 2/2] cvsimport: cleanup commit function Junio C Hamano
2006-05-23 20:32 ` Martin Langhoff
2006-05-23 16:50 ` Linus Torvalds
2006-05-23 19:36 ` Linus Torvalds
2006-05-23 20:25 ` Junio C Hamano
2006-05-23 20:29 ` Martin Langhoff
2006-05-23 21:10 ` Jeff King
2006-05-23 21:13 ` Martin Langhoff
2006-05-23 17:47 ` Morten Welinder
2006-05-23 20:59 ` Jeff King
2006-05-23 23:41 ` Junio C Hamano
2006-05-24 9:52 ` Jeff King
2006-05-22 20:16 ` irc usage Donnie Berkholz
2006-05-21 9:46 ` Thomas Glanzmann
2006-05-21 1:14 ` Donnie Berkholz
2006-05-22 1:45 ` Linus Torvalds
[not found] <1148369266352-git-send-email-1>
2006-05-23 7:27 ` [PATCH 2/2] cvsimport: cleanup commit function Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46a038f90605230113x2f6b0e4bq5a2ea97308b495e0@mail.gmail.com \
--to=martin.langhoff@gmail.com \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
--cc=smurf@smurf.noris.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).