git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Martin Langhoff" <martin.langhoff@gmail.com>
To: "Junio C Hamano" <junkio@cox.net>
Cc: "Martin Langhoff (CatalystIT)" <martin@catalyst.net.nz>,
	git@vger.kernel.org
Subject: Re: [PATCH] git-cvsimport: add suport for CVS pserver method HTTP/1.x proxying
Date: Fri, 24 Nov 2006 12:52:13 +1300	[thread overview]
Message-ID: <46a038f90611231552x3e33eec4w7863ce6a1da5781b@mail.gmail.com> (raw)
In-Reply-To: <7vlkm1ix7b.fsf@assigned-by-dhcp.cox.net>

On 11/24/06, Junio C Hamano <junkio@cox.net> wrote:
> It is more about HTTP proxying and it is my understanding that
> response to CONNECT method request has that empty line after the
> successful (2xx) response line and zero or more response
> headers.  The code is still wrong; it does not have a loop to
> discard the potential response headers that come before the
> empty line the code we are discussing discards.

You are right. It should be something along the lines of

  # discard headers until first blank line
  while (<$s> ne '') {
      # nothing
  }

that is, assuming we can just ignore headers happily.

cheers,




  parent reply	other threads:[~2006-11-23 23:52 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-22 22:26 [PATCH] git-cvsimport: add suport for CVS pserver method HTTP/1.x proxying Inaki Arenaza
     [not found] ` <7v64 d5keke.fsf@assigned-by-dhcp.cox.net>
2006-11-23 22:01 ` Junio C Hamano
2006-11-23 22:09   ` Martin Langhoff (CatalystIT)
2006-11-23 23:02     ` Junio C Hamano
2006-11-23 23:20       ` Martin Langhoff (CatalystIT)
2006-11-23 23:52       ` Martin Langhoff [this message]
2006-11-24  0:24         ` Junio C Hamano
2006-11-25 12:43           ` Ignacio Arenaza
2006-11-24  1:42         ` Jeff King
2006-11-24  2:54           ` Junio C Hamano
2006-11-24  8:43   ` Ignacio Arenaza
2006-11-24  8:46   ` Ignacio Arenaza
2006-11-24  8:57     ` Junio C Hamano
2006-11-24  9:05       ` Ignacio Arenaza
2006-11-24 11:48         ` Junio C Hamano
2006-11-27 16:27           ` Ignacio Arenaza
2006-11-24 14:57       ` Jeff King
2006-11-24  4:48 ` Christian Couder
2006-11-24  8:41   ` Ignacio Arenaza

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46a038f90611231552x3e33eec4w7863ce6a1da5781b@mail.gmail.com \
    --to=martin.langhoff@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=junkio@cox.net \
    --cc=martin@catalyst.net.nz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).