git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Martin Langhoff" <martin.langhoff@gmail.com>
To: git@vger.kernel.org, junkio@cox.net
Subject: Re: [PATCH] cvsimport: skip commits that are too recent
Date: Mon, 8 Jan 2007 20:17:25 +1300	[thread overview]
Message-ID: <46a038f90701072317h9bede00o939d4c078ccd569c@mail.gmail.com> (raw)
In-Reply-To: <11682386193246-git-send-email-martin@catalyst.net.nz>

On 1/8/07, Martin Langhoff <martin@catalyst.net.nz> wrote:
> With this patch, cvsimport will skip commits made
> in the last 10 minutes. The recent-ness test is of
> 5 minutes + cvsps fuzz window (5 minutes default).

Here is the repost with appropriate doco and an override ;-)

In related news, I am trying to debug an import that consistently
skips over remote commits... which is bad, bad news. The culprit seems
to be cvsps -- it skips commits it clearly knows about, and I'm not
sure why. I do think those were commits that cvsps saw half-baked in
the first place.

Passing -x to cvsps does bring those commits back, cvsps with -x can
afford to rewrite history a little bit. As long as the history being
rewritten is not too old we are safe. So with this patch, passing -x
is safer, assuming that 10 minutes is enough of a time window for
cvsps to change opinion about the project history.

 (Before you ask: from a data correctness, this is a fine mess.)

For this repo, I'll start running cvsimport with -o ' -x ' and see how
it behaves. Time-wise, the bandwidth usage and cpu times are roughly
similar for me using --cvs-direct. The patch to do it by default in
cvsimport is trivial, but I'm not entirely happy with the concept just
now.

In any case -- this should be a bit of a warning. cvsps is not
particularly reliable (not that cvs data ever is!), and passing -o '
-x' may help.

cheers,


martin

  reply	other threads:[~2007-01-08  7:17 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-08  6:43 [PATCH] cvsimport: skip commits that are too recent Martin Langhoff
2007-01-08  7:17 ` Martin Langhoff [this message]
2007-01-08  8:24   ` Martin Langhoff
2007-01-11  8:22 ` Robin Rosenberg
2007-01-11 20:18   ` Martin Langhoff
  -- strict thread matches above, loose matches on Subject: below --
2007-01-08  1:11 Martin Langhoff
2007-01-08  1:59 ` Junio C Hamano
2007-01-08  2:13   ` Martin Langhoff
2007-01-08  2:19     ` Junio C Hamano
2007-01-08  3:18       ` Martin Langhoff

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46a038f90701072317h9bede00o939d4c078ccd569c@mail.gmail.com \
    --to=martin.langhoff@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=junkio@cox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).