git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Martin Langhoff" <martin.langhoff@gmail.com>
To: "Nicolas Pitre" <nico@cam.org>
Cc: "Sam Vilain" <sam@vilain.net>, "Dana How" <danahow@gmail.com>,
	"Junio C Hamano" <gitster@pobox.com>,
	git@vger.kernel.org
Subject: Re: [PATCH] [RFC] Generational repacking
Date: Fri, 8 Jun 2007 07:46:26 +1200	[thread overview]
Message-ID: <46a038f90706071246y7dd14f55t199b8ed4e7617b68@mail.gmail.com> (raw)
In-Reply-To: <alpine.LFD.0.99.0706062314410.12885@xanadu.home>

On 6/7/07, Nicolas Pitre <nico@cam.org> wrote:
> Run git-repack without -a from some hook.  You can even launch it in the
> background.

I posted an RFC patch a while ago doing exactly that, and Linus shot
it down, indicating we should instead print a message suggesting
repack to the user.

Relevant thread around
http://www.gelato.unsw.edu.au/archives/git/0606/22977.html

> Or what am I missing?

I don't think people were comfortable at the time with concurrent
repacks -- though the semantics are safe if we don't hit any bug. My
guess is that noone wants to risk the .001% chances of data corruption
for this nice-to-have.

It was also probably a bad idea in my patch that it said -a -- it should just be

  git repack -l -q &

[And I generally agree with the concerns about possibly broken
semantics, unexpected user actions and racing repacks. One of the main
reasons I've never advocated SVN is that the early stories of data
corruption using BDB backends made me very very very wary of it.
Perhaps because I lot months of work in the past to disk corruption in
a cvs repo, and have a good mental picture of the nervous breakdown
that followed.]

cheers,


m

  parent reply	other threads:[~2007-06-07 19:46 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-06 11:08 [PATCH] [RFC] Generational repacking Sam Vilain
2007-06-06 22:46 ` Junio C Hamano
2007-06-06 22:53   ` Sam Vilain
2007-06-07  0:04 ` Dana How
2007-06-07  2:28   ` Sam Vilain
2007-06-07  3:20     ` Nicolas Pitre
2007-06-07  5:13       ` Sam Vilain
2007-06-07 13:38         ` Nicolas Pitre
2007-06-07 21:29           ` Sam Vilain
2007-06-07 19:46       ` Martin Langhoff [this message]
2007-06-07 21:36         ` Sam Vilain
2007-06-07 22:51           ` Martin Langhoff
2007-06-07  3:05   ` Nicolas Pitre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46a038f90706071246y7dd14f55t199b8ed4e7617b68@mail.gmail.com \
    --to=martin.langhoff@gmail.com \
    --cc=danahow@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=nico@cam.org \
    --cc=sam@vilain.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).