git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Martin Langhoff" <martin.langhoff@gmail.com>
To: "Git Mailing List" <git@vger.kernel.org>
Subject: blame follows renames, but log doesn't
Date: Tue, 19 Jun 2007 13:10:28 +1200	[thread overview]
Message-ID: <46a038f90706181810p716f914al4d9abba5bfe7eb5@mail.gmail.com> (raw)

Hi all,

when I show git to newbies or demo it to people using other SCMs, and
we get to the rename part of the conversation, I discuss and show how
GIT's approach is significantly better than explicit recording of
renames.

One great example is git-blame -- actually more spectacular with the
recent git gui blame improvements. But git-log still doesn't do it.

If I say
   git blame git-cvsimport.perl  # goes to the true origin like a champ
   git log git-cvsimport.perl # stops at the Big Tool Rename

In thread in May Linus posted a PoC patch to get git-blame to do it
http://marc.info/?l=git&m=117347893211567&w=2 , and outlined the
reasons why it'd be wrong to try to do that in git-log -- but it
didn't come to happen :-/

cg-log used to have some Perl logic that could do this -- it didn't
always work, but I'm sometimes tempted to go back to it, and review
it.

Linus said:
> But it's an example of the fact that yes, git can do this, but we're so
> stupid that we don't really accept it.

And I'm sure people can cope with git blame --log path/to/file and we
can add a note to git-log manpage about renames being reported by
blame instead.

And I kind of hate having to reply to things like these

    http://www.markshuttleworth.com/archives/125


cheers


martin

             reply	other threads:[~2007-06-19  1:10 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-19  1:10 Martin Langhoff [this message]
2007-06-19  1:34 ` blame follows renames, but log doesn't Sam Vilain
2007-06-19  7:19 ` Theodore Tso
2007-06-19  8:31   ` Martin Langhoff
2007-06-19  8:39   ` Junio C Hamano
2007-06-19  9:54   ` Steven Grimm
2007-06-19 18:28     ` Directory renames (was Re: blame follows renames, but log doesn't) Steven Grimm
2007-06-20 20:18       ` Sam Vilain
2007-06-20 20:59         ` Steven Grimm
2007-06-20 22:11     ` blame follows renames, but log doesn't Jakub Narebski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46a038f90706181810p716f914al4d9abba5bfe7eb5@mail.gmail.com \
    --to=martin.langhoff@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).