From: "Martin Langhoff" <martin.langhoff@gmail.com>
To: "Frank Lichtenheld" <frank@lichtenheld.de>
Cc: "Git Mailing List" <git@vger.kernel.org>,
"Junio C Hamano" <junkio@cox.net>
Subject: Re: [PATCH] cvsserver: Fix req_update to handle packed refs
Date: Fri, 5 Oct 2007 09:43:55 +1300 [thread overview]
Message-ID: <46a038f90710041343g5b6a5a30gcd0c9f18d265fa28@mail.gmail.com> (raw)
In-Reply-To: <1191525680-10481-1-git-send-email-frank@lichtenheld.de>
On 10/5/07, Frank Lichtenheld <frank@lichtenheld.de> wrote:
> cvsserver returns a list of existing modules on command
> 'update' without a module specified (apparently this is
> used by some clients to get a list of available modules,
> the CVS cli client doesn't support it).
>
> Fix this code to work correctly in presence of packed refs.
> (Use git-branch instead of reading refs/heads/)
ACK - good stuff - thanks!
There is one minor issue around this I suspect - refs with slashes in
them. Without this patch, only refs that literally sit in refs/heads
will be returned. With git branches, you could see oldbranches/foo
being returned to the client.
IIRC - the behaviour cvsserver supports here is completely
unspecified, and clients will probably error out in weird and wacky
ways. I'd perhaps filter out any headref with a slash.
cheers,
martin
next prev parent reply other threads:[~2007-10-04 20:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-04 19:21 [PATCH] cvsserver: Fix req_update to handle packed refs Frank Lichtenheld
2007-10-04 20:43 ` Martin Langhoff [this message]
2007-10-04 20:58 ` Frank Lichtenheld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46a038f90710041343g5b6a5a30gcd0c9f18d265fa28@mail.gmail.com \
--to=martin.langhoff@gmail.com \
--cc=frank@lichtenheld.de \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).