Re: [PATCH 0/3] git-cvsserver: Add support for some binary files

["Martin Langhoff" <martin.langhoff@gmail.com>]

On Sat, May 17, 2008 at 12:03 PM, Junio C Hamano <junio@pobox.com> wrote:
> Matthew Ogilvie <mmogilvi_git@miniinfo.net> writes:
>
>> This series of patches extends git-cvsserver to support telling the
>> CVS client to set the -kb (binary) mode for files that git considers
>> to be binary (and not for text files).  It includes updates to
>> documentation and tests.
>
> I am unfortunately not familiar with this part of the system and I'd need
> to summon help from experts, but it looks rather nicely done.

Looks good.

I was at first a bit troubled - "cvsserver doesn't do keyword
expansion anyway" was my first thought - but it makes sense to have
this to help newline-munging clients.

IIRC, one thing that is _not_ handled well in CVS -k flag changes on
the server side (since -k modes are not versioned). If we are
guessing, this may be more likely to happen, or at least more likely
to _surprise_ people.

Matthew, have you had a chance to test k mode changes against clients?
Are we reasonably bug-compatible with the original turd^H^H^Hhing? ;-)

Sorry about the latency!

cheers,



m
-- 
 martin.langhoff@gmail.com
 martin@laptop.org -- School Server Architect
 - ask interesting questions
 - don't get distracted with shiny stuff - working code first
 - http://wiki.laptop.org/go/User:Martinlanghoff