From: "Ping Yin" <pkufranky@gmail.com>
To: "Junio C Hamano" <gitster@pobox.com>
Cc: git@vger.kernel.org, "Shawn O. Pearce" <spearce@spearce.org>,
"Johannes Schindelin" <Johannes.Schindelin@gmx.de>
Subject: Re: Re* [PATCH] git-submodule: Don't blame when git-describe fails
Date: Mon, 3 Mar 2008 01:17:16 +0800 [thread overview]
Message-ID: <46dff0320803020917s154c204cl56d85e47de892173@mail.gmail.com> (raw)
In-Reply-To: <7vy791oyqa.fsf@gitster.siamese.dyndns.org>
On 3/3/08, Junio C Hamano <gitster@pobox.com> wrote:
> Ping Yin <pkufranky@gmail.com> writes:
>
> > Avoid 'fatal: cannot describe' message
> >
> > Signed-off-by: Ping Yin <pkufranky@gmail.com>
>
> I see you reworded the commit log somewhat in your second attempt. I
> would have written it this way, though:
>
> git-submodule: Avoid 'fatal: cannot describe' message
>
> When "git submodule status" command tries to show the name of the
> submodule HEAD revision more descriptively, but the submodule
> repository lacked a suitable tag to do so, it leaked "fatal: cannot
> describe" message to the UI. Squelch it.
>
That's ok. You can sign off it.
--
Ping Yin
next prev parent reply other threads:[~2008-03-02 17:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-02 14:45 [PATCH] git-submodule: Don't blame when git-describe fails Ping Yin
2008-03-02 16:51 ` Re* " Junio C Hamano
2008-03-02 17:17 ` Ping Yin [this message]
2008-03-02 22:41 ` Shawn O. Pearce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46dff0320803020917s154c204cl56d85e47de892173@mail.gmail.com \
--to=pkufranky@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).