git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Ping Yin" <pkufranky@gmail.com>
To: gitster@pobox.com
Cc: git@vger.kernel.org, "Ping Yin" <pkufranky@gmail.com>
Subject: Re: [PATCH v4 5/5] git-submodule summary: test
Date: Tue, 11 Mar 2008 09:57:27 +0800	[thread overview]
Message-ID: <46dff0320803101857t435ec42g93c3605ec64d710a@mail.gmail.com> (raw)
In-Reply-To: <1205171657-16216-5-git-send-email-pkufranky@gmail.com>

On Tue, Mar 11, 2008 at 1:54 AM, Ping Yin <pkufranky@gmail.com> wrote:
> Signed-off-by: Ping Yin <pkufranky@gmail.com>
>  ---
>   t/t7401-submodule-summary.sh |  194 ++++++++++++++++++++++++++++++++++++++++++
>  +
>  +sleep 1s
>  +head4=$(add_file sm1 foo4 foo5) &&
>  +head4_full=$(GIT_DIR=sm1/.git git rev-parse --verify HEAD)
>  +test_expect_success 'modified submodule(backward and forward)' "
>  +    git submodule summary >actual &&
>  +    diff actual - <<-EOF
>  +* sm1 $head2...$head4 (4):
>  +  > Add foo5
>  +  > Add foo4
>  +  < Add foo3
>  +  < Add foo2
>  +
>  +EOF
>  +"

'sleep 1s' is used to just make sure the summary result just has the
same commit order as i expected (the order is undefined if not using
this because the commit time are all the same).

However, it seems ugly. I will resend this patch later by using result
from 'git log --pretty=format' as the expected result.
>  +



-- 
Ping Yin

  reply	other threads:[~2008-03-11  1:58 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-10 17:54 [PATCH v4 1/5] git-submodule summary: code framework Ping Yin
2008-03-10 17:54 ` [PATCH v4 2/5] git-submodule summary: show commit summary Ping Yin
2008-03-10 17:54   ` [PATCH v4 3/5] git-submodule summary: limit summary size Ping Yin
2008-03-10 17:54     ` [PATCH v4 4/5] git-submodule summary: documentation Ping Yin
2008-03-10 17:54       ` [PATCH v4 5/5] git-submodule summary: test Ping Yin
2008-03-11  1:57         ` Ping Yin [this message]
2008-03-10 17:58   ` [PATCH v4 2/5] git-submodule summary: show commit summary Ping Yin
2008-03-11  1:52   ` Ping Yin
2008-03-11  7:28   ` Junio C Hamano
2008-03-11  9:37     ` Ping Yin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46dff0320803101857t435ec42g93c3605ec64d710a@mail.gmail.com \
    --to=pkufranky@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).