From: "Ping Yin" <pkufranky@gmail.com>
To: "Junio C Hamano" <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v5 2/5] git-submodule summary: show commit summary
Date: Wed, 12 Mar 2008 10:30:35 +0800 [thread overview]
Message-ID: <46dff0320803111930r5ffe10b8k49a777ce3481643@mail.gmail.com> (raw)
In-Reply-To: <7vwso8adxh.fsf@gitster.siamese.dyndns.org>
On Wed, Mar 12, 2008 at 10:12 AM, Junio C Hamano <gitster@pobox.com> wrote:
>
> "Ping Yin" <pkufranky@gmail.com> writes:
>
> > On Tue, Mar 11, 2008 at 9:52 PM, Ping Yin <pkufranky@gmail.com> wrote:
> >> This patch does the hard work to show submodule commit summary.
> >>
> >
> >> + case "$mod_dst" in
> >> + 160000)
> >> + sha1_dst=$(GIT_DIR="$name/.git" git rev-parse HEAD)
> >> + ;;
> >> + 100644)
> >> + sha1_dst=$(git hash-object $name)
> >> + ;;
> >> + esac
> >
> > please s/100644/100*/
>
> How would that help symbolic links?
>
I am not familiar with git core code, could you tell me where to find
all file mod for various types?
--
Ping Yin
next prev parent reply other threads:[~2008-03-12 2:31 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-11 13:52 [PATCH v5 0/5] git-submodule summary Ping Yin
2008-03-11 13:52 ` [PATCH v5 1/5] git-submodule summary: code framework Ping Yin
2008-03-11 13:52 ` [PATCH v5 2/5] git-submodule summary: show commit summary Ping Yin
2008-03-11 13:52 ` [PATCH v5 3/5] git-submodule summary: limit summary size Ping Yin
2008-03-11 13:52 ` [PATCH v5 4/5] git-submodule summary: documentation Ping Yin
2008-03-11 13:52 ` [PATCH v5 5/5] git-submodule summary: test Ping Yin
2008-03-12 2:08 ` [PATCH v5 2/5] git-submodule summary: show commit summary Ping Yin
2008-03-12 2:12 ` Junio C Hamano
2008-03-12 2:30 ` Ping Yin [this message]
2008-03-12 4:12 ` Junio C Hamano
2008-03-12 4:28 ` Ping Yin
2008-03-12 6:15 ` Junio C Hamano
2008-03-12 8:27 ` Ping Yin
2008-03-12 8:30 ` [PATCH] git-submodule summary: fix that some "wc" flavors produce leading spaces Johannes Sixt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46dff0320803111930r5ffe10b8k49a777ce3481643@mail.gmail.com \
--to=pkufranky@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).