From: "Ping Yin" <pkufranky@gmail.com>
To: "Johannes Sixt" <j.sixt@viscovery.net>
Cc: git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH 1/3] builtin-status: submodule summary support
Date: Thu, 13 Mar 2008 21:05:17 +0800 [thread overview]
Message-ID: <46dff0320803130605g492ebc89y9476aba6ae729d9f@mail.gmail.com> (raw)
In-Reply-To: <47D78753.2040902@viscovery.net>
>
> Where is summary_limit? Did you split this patch series incorrectly?
>
> > + s->amend ? "HEAD^" : "HEAD",
>
> Any chance that we avoid "HEAD^" here? Perhaps we have the SHA1 around
> somewhere? I fear that our MSYS bash mangles it into "HEAD". I shall test it.
>
I am not familiar with git core code, and don't find a way to avoid 'HEAD^' yet
--
Ping Yin
prev parent reply other threads:[~2008-03-13 13:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-12 2:21 [PATCH 1/3] builtin-status: submodule summary support Ping Yin
2008-03-12 2:21 ` [PATCH 2/3] builtin-status: configurable submodule summary size Ping Yin
2008-03-12 2:21 ` [PATCH 3/3] buitin-status: Add tests for submodule summary Ping Yin
2008-03-12 7:38 ` Johannes Sixt
2008-03-12 7:33 ` [PATCH 1/3] builtin-status: submodule summary support Johannes Sixt
2008-03-13 13:05 ` Ping Yin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46dff0320803130605g492ebc89y9476aba6ae729d9f@mail.gmail.com \
--to=pkufranky@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j.sixt@viscovery.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).