Re: [PATCH v2 0/5] builtin-status submodule summary

["Ping Yin" <pkufranky@gmail.com>]

On Sat, Mar 15, 2008 at 12:22 AM, Johannes Sixt <j.sixt@viscovery.net> wrote:
> Ping Yin schrieb:
>
> > IMO, git submodule summary is not so useful for me if it's not
>  > integrated into git-status. In fact i never use "git submodule
>  > summary" directly. git-status with submodule summary support is very
>  > useful to help user figure out what is going on in a more global level
>  > when cooking the commit message.
>  >
>  > So i think this series should go along with the submodule summary series.
>
>  I think so, too. The changes and defaults in wt-status.c are trivial
>  enough that they don't penalize traditional git-status users.
>
>
>  > The v2 series has following commits adding a new commit for documentation
>  >
>  >     1  git-submodule summary: --for-status option
>  >     2  builtin-status: submodule summary support
>  >     3  builtin-status: configurable submodule summary size
>  >     4  buitin-status: Add tests for submodule summary
>  >     5  git-status: Mention status.submodulesummary config in the documentation
>
>  I'd actually squash 2, 3, and 5.
>
>  You still have the statement before a declaration in 3/5.
Sorry i forgot about it.

>
>
>  > +     if (! wt_status_submodule_summary) return;
>
>  And here the important part (IMO) is actually that 'return' should go on a
>  line of its own.
OK



-- 
Ping Yin