git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Ping Yin" <pkufranky@gmail.com>
To: "Johannes Sixt" <j.sixt@viscovery.net>
Cc: "Git Mailing List" <git@vger.kernel.org>
Subject: Re: [regression?] "git status -a" reports modified for empty submodule directory
Date: Tue, 22 Apr 2008 20:39:56 +0800	[thread overview]
Message-ID: <46dff0320804220539y51c02dedoe181a0eed8599902@mail.gmail.com> (raw)
In-Reply-To: <480DD6D8.9040900@viscovery.net>

On Tue, Apr 22, 2008 at 8:15 PM, Johannes Sixt <j.sixt@viscovery.net> wrote:
> Ping Yin schrieb:
>
> > # create a super project super
>  > $ mkdir super && cd super && git init
>  > $ touch foo && git add foo && git commit -m "add foo"
>  >
>  > # create a sub project sub
>  > $ mkdir sub && cd sub && git init
>  > $ touch bar && git add bar && git commit -m "add bar"
>  >
>  > # add sub project to super project
>  > $ cd ..
>  > $ git add sub && git commit -m 'add sub'
>  >
>  > # remote contents of subproject
>  > $ rm -rf sub/* sub/.git
>  >
>  > # git status -a regression
>  > $ git status
>  > # On branch master
>  > nothing to commit (working directory clean)
>
>  This should have reported:
>
>  # On branch master
>  # Changed but not updated:
>  #   (use "git add/rm <file>..." to update what will be committed)
>  #
>  #       deleted:    sub
>  no changes added to commit (use "git add" and/or "git commit -a")
>
>  Right?
>
>
>  > $ git status -a
>  > # On branch master
>  > # Changes to be committed:
>  > #   (use "git reset HEAD <file>..." to unstage)
>  > #
>  > #       deleted:    sub
>  > #
>
>  There's nothing wrong with this.
>
>  -- Hannes

It seems that in 1.5.4, both 'git status' and 'git status -a' report
"no changes added to commit". And i think this is the right behaviour.
Because when a super project is cloned, all submodule directories are
empty in the beginning. In this case 'git status' and 'git status -a'
should report " no changes added to commit".



-- 
Ping Yin

  reply	other threads:[~2008-04-22 12:40 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-22 11:01 [regression?] "git status -a" reports modified for empty submodule directory Ping Yin
2008-04-22 11:04 ` Ping Yin
2008-04-22 12:15 ` Johannes Sixt
2008-04-22 12:39   ` Ping Yin [this message]
2008-04-22 12:46     ` Johannes Sixt
2008-04-22 18:00     ` Roman Shaposhnik
2008-04-29 15:31 ` Ping Yin
2008-04-29 16:07   ` [PATCH 0/2] Add tests for submodule with empty directory Ping Yin
2008-04-29 16:07     ` [PATCH 1/2] t4027: test diff " Ping Yin
2008-04-29 16:07       ` [PATCH 2/2] Add t7506 to test submodule related functions for git-status Ping Yin
2008-04-29 21:40   ` [regression?] "git status -a" reports modified for empty submodule directory Junio C Hamano
2008-04-30  6:39     ` Johannes Sixt
2008-04-30  7:29       ` Junio C Hamano
2008-04-30 15:56         ` Ping Yin
2008-05-02 13:35           ` [PATCH 0/4] Fix regression for unchecked out submodules Ping Yin
2008-05-02 13:35             ` [PATCH 1/4] t4027: test diff for submodule with empty directory Ping Yin
2008-05-02 13:35               ` [PATCH 2/4] Add t7506 to test submodule related functions for git-status Ping Yin
2008-05-02 13:35                 ` [PATCH 3/4] Fix diff regression for submodules not checked out Ping Yin
2008-05-02 13:35                   ` [PATCH 4/4] Fix ie_match_stat for non-checked-out submodule Ping Yin
2008-05-02 21:57                     ` Junio C Hamano
2008-05-02 23:34                       ` Ping Yin
2008-05-02 22:23                   ` [PATCH 3/4] Fix diff regression for submodules not checked out Junio C Hamano
2008-05-02 23:55                     ` Ping Yin
2008-05-03  0:07                     ` [PATCH] Rename ENT_INEXISTENT to ENT_NONEXISTENT Ping Yin
2008-05-03 12:36                     ` [PATCH 3/4] Fix diff regression for submodules not checked out Johannes Schindelin
2008-05-03 16:59                       ` Junio C Hamano
2008-05-04  6:45                     ` Junio C Hamano
2008-05-04  7:10                       ` Ping Yin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46dff0320804220539y51c02dedoe181a0eed8599902@mail.gmail.com \
    --to=pkufranky@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=j.sixt@viscovery.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).