From: "Ping Yin" <pkufranky@gmail.com>
To: "Junio C Hamano" <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 4/4] Fix ie_match_stat for non-checked-out submodule
Date: Sat, 3 May 2008 07:34:00 +0800 [thread overview]
Message-ID: <46dff0320805021634oa7500e8hee004a6e328fd0fa@mail.gmail.com> (raw)
In-Reply-To: <7vod7owerk.fsf@gitster.siamese.dyndns.org>
On Sat, May 3, 2008 at 5:57 AM, Junio C Hamano <gitster@pobox.com> wrote:
>
> --- a/read-cache.c
> +++ b/read-cache.c
> @@ -258,6 +258,7 @@ static int ce_match_stat_basic(struct cache_entry *ce, struct stat *st)
> static int is_racy_timestamp(const struct index_state *istate, struct cache_entry *ce)
> {
> return (istate->timestamp &&
> + !S_ISGITLINK(ce->ce_mode) &&
> ((unsigned int)istate->timestamp) <= ce->ce_mtime);
> }
>
fine
--
Ping Yin
next prev parent reply other threads:[~2008-05-02 23:34 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-22 11:01 [regression?] "git status -a" reports modified for empty submodule directory Ping Yin
2008-04-22 11:04 ` Ping Yin
2008-04-22 12:15 ` Johannes Sixt
2008-04-22 12:39 ` Ping Yin
2008-04-22 12:46 ` Johannes Sixt
2008-04-22 18:00 ` Roman Shaposhnik
2008-04-29 15:31 ` Ping Yin
2008-04-29 16:07 ` [PATCH 0/2] Add tests for submodule with empty directory Ping Yin
2008-04-29 16:07 ` [PATCH 1/2] t4027: test diff " Ping Yin
2008-04-29 16:07 ` [PATCH 2/2] Add t7506 to test submodule related functions for git-status Ping Yin
2008-04-29 21:40 ` [regression?] "git status -a" reports modified for empty submodule directory Junio C Hamano
2008-04-30 6:39 ` Johannes Sixt
2008-04-30 7:29 ` Junio C Hamano
2008-04-30 15:56 ` Ping Yin
2008-05-02 13:35 ` [PATCH 0/4] Fix regression for unchecked out submodules Ping Yin
2008-05-02 13:35 ` [PATCH 1/4] t4027: test diff for submodule with empty directory Ping Yin
2008-05-02 13:35 ` [PATCH 2/4] Add t7506 to test submodule related functions for git-status Ping Yin
2008-05-02 13:35 ` [PATCH 3/4] Fix diff regression for submodules not checked out Ping Yin
2008-05-02 13:35 ` [PATCH 4/4] Fix ie_match_stat for non-checked-out submodule Ping Yin
2008-05-02 21:57 ` Junio C Hamano
2008-05-02 23:34 ` Ping Yin [this message]
2008-05-02 22:23 ` [PATCH 3/4] Fix diff regression for submodules not checked out Junio C Hamano
2008-05-02 23:55 ` Ping Yin
2008-05-03 0:07 ` [PATCH] Rename ENT_INEXISTENT to ENT_NONEXISTENT Ping Yin
2008-05-03 12:36 ` [PATCH 3/4] Fix diff regression for submodules not checked out Johannes Schindelin
2008-05-03 16:59 ` Junio C Hamano
2008-05-04 6:45 ` Junio C Hamano
2008-05-04 7:10 ` Ping Yin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46dff0320805021634oa7500e8hee004a6e328fd0fa@mail.gmail.com \
--to=pkufranky@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).