git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Ping Yin" <pkufranky@gmail.com>
To: "Git Mailing List" <git@vger.kernel.org>
Subject: git and peer review
Date: Sat, 3 May 2008 09:02:41 +0800	[thread overview]
Message-ID: <46dff0320805021802i1a29becflcae901315035a77d@mail.gmail.com> (raw)

I have tried many online review tools: cucible, reviewboard and
smartcollaborator. The are both great. However, they can't satisfy all
my requirements:

1. poor git support
2. When reviewing changes between revision (or commit for git) a and
revision b, they display all changes as a single diff instead of one
diff for each intermediate revision

So finally, i decide to use git itself as the reviewing tool if i
can't find better.

I am in a company environment and i want to enforce a policy that
every commit must be reviewed before pushed to central repository. I
think i can use hooks to enforce such kind of policy.

One way i want to try is to check in the hook whether every pushed
commit has a "Reviewed-by " line .  Any suggestion?

And one question, how to add a "Reviewed-by" line automatically?

The reviewers sit near each other, so we do face-to-face peer review
and don't pass patches by email.
Say,  i have prepared a patch series,

Case 1
    I ask someone to review my patches at my machine. If the review
passes, i have to add Reviewed-by line to each commit and then merge
it to the master branch. However, i find no easy way to add
reviewed-by line. Maybe adding --reviewed-by  option to cherry-pick or
rebase or merge?

Case 2
   The reviewer is the maintainer, so i ask him to pull and review. So
now it is his turn to add review-by line. But still, how?

-- 
Ping Yin

             reply	other threads:[~2008-05-03  1:03 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-03  1:02 Ping Yin [this message]
2008-05-03 13:54 ` git and peer review Thomas Adam
2008-05-03 14:03   ` Ping Yin
2008-05-03 14:22     ` Frodo Baggins
2008-05-03 14:27       ` Ping Yin
2008-05-04 20:21 ` Toby Allsopp
2008-05-05  0:52   ` Ping Yin
2008-05-05 13:48   ` Karl Hasselström
2008-05-17 21:30   ` Seth Falcon
2008-05-19  3:37     ` Shawn O. Pearce
2008-05-19 14:10       ` Seth Falcon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46dff0320805021802i1a29becflcae901315035a77d@mail.gmail.com \
    --to=pkufranky@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).