From: Johannes Sixt <j.sixt@viscovery.net>
To: Martin Waitz <tali@admingilde.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] git-init: don't base core.filemode on the ability to chmod.
Date: Wed, 03 Oct 2007 14:19:40 +0200 [thread overview]
Message-ID: <470388DC.4040504@viscovery.net> (raw)
In-Reply-To: <20071003105501.GD7085@admingilde.org>
Martin Waitz schrieb:
> At least on Linux the vfat file system honors chmod calls but does not
> store them permanently (as there is no on-disk format for it).
> So the filemode test which tries to chmod a file thinks that the file
> system does support file modes. This will result in problems when the
> file system gets mounted for the next time and all the executable bits
> are back.
>
> A more reliable test for file systems without filemode support is to
> simply check if new files are created with the executable bit set.
On Windows, we don't get an executable bit at all. Better use both
heuristics, i.e. set core.filemode false if either one diagnoses an
unreliable x-bit.
-- Hannes
next prev parent reply other threads:[~2007-10-03 12:20 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-03 10:55 [PATCH] git-init: don't base core.filemode on the ability to chmod Martin Waitz
2007-10-03 12:19 ` Johannes Sixt [this message]
2007-10-03 23:19 ` Martin Waitz
2007-10-03 23:54 ` Johannes Schindelin
2007-10-04 6:05 ` Andreas Ericsson
2007-10-04 6:23 ` Junio C Hamano
2007-10-04 7:17 ` Martin Waitz
2007-10-04 8:21 ` Junio C Hamano
2007-10-04 8:36 ` Johannes Sixt
2007-10-04 8:42 ` Martin Waitz
2007-10-10 9:47 ` Jan Hudec
2007-10-04 12:49 ` Johannes Schindelin
2007-10-04 10:33 ` Andreas Ericsson
2007-10-04 7:15 ` Martin Waitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=470388DC.4040504@viscovery.net \
--to=j.sixt@viscovery.net \
--cc=git@vger.kernel.org \
--cc=tali@admingilde.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).