From: Marko Macek <Marko.Macek@gmx.net>
To: "Kristian Høgsberg" <krh@redhat.com>
Cc: Andreas Ericsson <ae@op5.se>,
Paolo Ciarrocchi <paolo.ciarrocchi@gmail.com>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Nguyen Thai Ngoc Duy <pclouds@gmail.com>,
Wincent Colaiuta <win@wincent.com>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: Question about "git commit -a"
Date: Fri, 05 Oct 2007 20:16:08 +0200 [thread overview]
Message-ID: <47067F68.2080709@gmx.net> (raw)
In-Reply-To: <1191599763.7117.18.camel@hinata.boston.redhat.com>
> I understand why people like staging and commit without -a, seeing how
> it's faster and all, but I have a serious problem with this practice
> that I haven't seen brought up on the list. How do you know what you
> commit actually works or even compiles? The reason that I almost
> exclusively use -a with commit is that I want to know that what I just
> compiled and tested is what I will be committing. I don't want to just
> commit half the files in my working copy, I want to make sure that the
> exact state of my project that I just compiled and tested is what gets
> into version controlled history.
>
> git commit -a isn't sloppy to me - eye balling some subset of your
> working copy and committing that under the assumption that you don't
> make mistakes and don't need to compile what you commit... that is
> sloppy.
Agreed. For this reason git-commit without -a, staging, index, ... is
not really interesting to me.
In CVS and subversion (which has nicer working-copy command line interface IMHO),
I simply make a copy of the working copy, revert the non-commitable parts, build,
commit the minor changes, and then update the first copy. For larger projects,
where this can be slow, I use diff/revert/patch.
Small checkins are nice for git-bisect, but if they don't build...
Mark
next prev parent reply other threads:[~2007-10-05 18:18 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-04 15:38 Question about "git commit -a" Paolo Ciarrocchi
2007-10-04 15:43 ` Matthieu Moy
2007-10-04 15:48 ` Paolo Ciarrocchi
2007-10-04 15:58 ` Wincent Colaiuta
2007-10-04 20:33 ` Nguyen Thai Ngoc Duy
2007-10-04 21:10 ` Johannes Schindelin
2007-10-04 21:16 ` Nguyen Thai Ngoc Duy
2007-10-04 21:26 ` Shawn O. Pearce
2007-10-05 8:39 ` Paolo Ciarrocchi
2007-10-05 8:52 ` Andreas Ericsson
2007-10-05 9:06 ` Paolo Ciarrocchi
2007-10-05 10:02 ` Andreas Ericsson
2007-10-05 10:11 ` Matthieu Moy
2007-10-05 10:14 ` Andreas Ericsson
2007-10-05 11:35 ` Matthieu Moy
2007-10-05 12:17 ` Andreas Ericsson
2007-10-05 12:19 ` Paolo Ciarrocchi
2007-10-05 12:23 ` Andreas Ericsson
2007-10-05 12:45 ` Matthieu Moy
2007-10-05 15:56 ` Kristian Høgsberg
2007-10-05 16:33 ` Matthieu Moy
2007-10-05 18:16 ` Marko Macek [this message]
2007-10-06 7:43 ` Andy Parkins
2007-10-06 16:13 ` Linus Torvalds
2007-10-07 12:26 ` Wincent Colaiuta
2007-10-05 21:10 ` Dmitry Potapov
2007-10-07 6:12 ` Marko Macek
2007-10-07 14:50 ` Dmitry Potapov
2007-10-07 16:26 ` Johannes Schindelin
2007-10-05 10:48 ` Wincent Colaiuta
2007-10-04 21:25 ` Andy Parkins
2007-10-05 6:04 ` Miles Bader
2007-10-04 22:34 ` David Soria
2007-10-04 23:03 ` Alex Riesen
2007-10-04 23:19 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47067F68.2080709@gmx.net \
--to=marko.macek@gmx.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=ae@op5.se \
--cc=git@vger.kernel.org \
--cc=krh@redhat.com \
--cc=paolo.ciarrocchi@gmail.com \
--cc=pclouds@gmail.com \
--cc=win@wincent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).