From: Johannes Sixt <j.sixt@viscovery.net>
To: Steffen Prohaska <prohaska@zib.de>
Cc: Johannes.Schindelin@gmx.de, git@vger.kernel.org
Subject: Re: [PATCH] exec_git_cmd: fix executing commands if path contains spaces
Date: Wed, 10 Oct 2007 08:16:56 +0200 [thread overview]
Message-ID: <470C6E58.3080208@viscovery.net> (raw)
In-Reply-To: <11919659771056-git-send-email-prohaska@zib.de>
Steffen Prohaska schrieb:
> Ok, this is what I created from the quick-fix. It works for
> me in msysgit.
>
> Should the patch be polished that it can be applied to git.git
> or will we only apply it to 4msysgit?
I'll apply it to mingw.git, and as long as you don't rebase or pull from
there, you'd also have to apply it to 4msysgit.
git.git is a no-go at this time - compat/mingw.c doesn't exist, yet.
> If it should be polished, what would be the right way?
> ifdef in exec_cmd.c?
This area needs more polishing, and it will be among the *last* mingw
patches that flow upstream.
BTW, I think the fix is incomplete anyway: We quote only argv[0], but
actually all of argv should be quoted. Will test.
-- Hannes
next prev parent reply other threads:[~2007-10-10 6:17 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-08 11:06 Merge problems with git-mingw Peter Karlsson
2007-10-08 12:00 ` Lars Hjemli
2007-10-08 12:33 ` Peter Karlsson
2007-10-08 13:10 ` Lars Hjemli
2007-10-08 14:56 ` Peter Karlsson
2007-10-08 19:59 ` Lars Hjemli
2007-10-09 6:10 ` Johannes Sixt
2007-10-09 7:06 ` Peter Karlsson
2007-10-09 7:36 ` Johannes Sixt
2007-10-09 8:56 ` Peter Karlsson
2007-10-09 9:03 ` Johannes Sixt
2007-10-09 16:33 ` Steffen Prohaska
2007-10-09 17:03 ` Johannes Sixt
2007-10-09 18:09 ` Linus Torvalds
2007-10-09 21:39 ` [PATCH] exec_git_cmd: fix executing commands if path contains spaces Steffen Prohaska
2007-10-10 6:16 ` Johannes Sixt [this message]
2007-10-10 7:00 ` [PATCH] Fix invocation of external git commands with arguments with spaces Johannes Sixt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=470C6E58.3080208@viscovery.net \
--to=j.sixt@viscovery.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=prohaska@zib.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).