From: Johannes Sixt <j.sixt@viscovery.net>
To: Andreas Ericsson <ae@op5.se>
Cc: Scott Parish <sRp@srparish.net>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
"Shawn O. Pearce" <spearce@spearce.org>,
git@vger.kernel.org
Subject: Re: [PATCH] execv_git_cmd(): also try PATH if everything else fails.
Date: Tue, 23 Oct 2007 17:29:49 +0200 [thread overview]
Message-ID: <471E136D.4010905@viscovery.net> (raw)
In-Reply-To: <471DD703.70608@op5.se>
Andreas Ericsson schrieb:
> Johannes Sixt wrote:
>> But I can't think of any negative side effect if *all* exec-path
>> candidates are in $PATH. It's important, though, that all paths are
>> absolute because the tools chdir every now and then.
>>
>
> So long as they're added in "success:failed:failed" order, I don't see
> any issues either. Assuming we stop prepending once we find something
> that works, that should be a non-issue.
No, the point is exactly to let execvp() do all the work and we don't care
which of the paths is the "success". And I don't think that this has any
negative side effects.
-- Hannes
next prev parent reply other threads:[~2007-10-23 15:30 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-20 8:12 [PATCH] When exec'ing sub-commands, fall back on execvp (thePATH) Scott R Parish
2007-10-20 20:25 ` Johannes Schindelin
2007-10-20 20:57 ` Scott Parish
2007-10-20 22:00 ` [PATCH] execv_git_cmd(): also try PATH if everything else fails Johannes Schindelin
2007-10-21 2:36 ` Shawn O. Pearce
2007-10-21 21:59 ` Johannes Schindelin
2007-10-22 4:21 ` Shawn O. Pearce
2007-10-22 10:35 ` Johannes Schindelin
2007-10-23 4:34 ` Shawn O. Pearce
2007-10-23 11:12 ` Johannes Schindelin
2007-10-22 14:36 ` Scott Parish
2007-10-22 15:19 ` Andreas Ericsson
2007-10-22 15:36 ` Johannes Sixt
2007-10-23 11:12 ` Andreas Ericsson
2007-10-23 15:29 ` Johannes Sixt [this message]
2007-10-21 18:21 ` Scott Parish
2007-10-21 22:02 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=471E136D.4010905@viscovery.net \
--to=j.sixt@viscovery.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=ae@op5.se \
--cc=git@vger.kernel.org \
--cc=sRp@srparish.net \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).