From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andreas Ericsson Subject: Re: [PATCH] git-format-patch: Number patches when there are more than one Date: Sat, 03 Nov 2007 17:34:09 +0100 Message-ID: <472CA301.50508@op5.se> References: <1194104694-12530-1-git-send-email-mh@glandium.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Cc: Mike Hommey , git@vger.kernel.org, spearce@spearce.org To: Johannes Schindelin X-From: git-owner@vger.kernel.org Sat Nov 03 17:34:31 2007 Return-path: Envelope-to: gcvg-git-2@gmane.org Received: from vger.kernel.org ([209.132.176.167]) by lo.gmane.org with esmtp (Exim 4.50) id 1IoLx7-0007e7-BQ for gcvg-git-2@gmane.org; Sat, 03 Nov 2007 17:34:29 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754726AbXKCQeP (ORCPT ); Sat, 3 Nov 2007 12:34:15 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754697AbXKCQeO (ORCPT ); Sat, 3 Nov 2007 12:34:14 -0400 Received: from mail.op5.se ([193.201.96.20]:36707 "EHLO mail.op5.se" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754613AbXKCQeO (ORCPT ); Sat, 3 Nov 2007 12:34:14 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.op5.se (Postfix) with ESMTP id 813651730695; Sat, 3 Nov 2007 17:33:07 +0100 (CET) X-Virus-Scanned: amavisd-new at X-Spam-Flag: NO X-Spam-Score: -2.499 X-Spam-Level: X-Spam-Status: No, score=-2.499 tagged_above=-10 required=6.6 tests=[BAYES_00=-2.599, RDNS_NONE=0.1] Received: from mail.op5.se ([127.0.0.1]) by localhost (mail.op5.se [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8urSt8XahOfA; Sat, 3 Nov 2007 17:33:06 +0100 (CET) Received: from nox.op5.se (unknown [172.27.78.10]) by mail.op5.se (Postfix) with ESMTP id 273F21730690; Sat, 3 Nov 2007 17:33:06 +0100 (CET) User-Agent: Thunderbird 2.0.0.5 (X11/20070727) In-Reply-To: Sender: git-owner@vger.kernel.org Precedence: bulk X-Mailing-List: git@vger.kernel.org Archived-At: Johannes Schindelin wrote: > Hi, > > On Sat, 3 Nov 2007, Mike Hommey wrote: > >> Automagically enable numbering if we output more than one patch. >> >> Signed-off-by: Mike Hommey >> --- >> >> On Mon, Oct 22, 2007 at 10:44:12AM +0100, Johannes Schindelin wrote: >>> Hi, >>> >>> On Sun, 21 Oct 2007, Andreas Ericsson wrote: >>> >>>> [PATCH 1/1] looks a bit silly, and automagically handling this in >>>> git-format-patch makes some scripting around it a lot more pleasant. >>> I think you should not use "-n" if you do not want to have the numbers. >>> In circumstances as yours, where you can have patch series larger than >>> one, I imagine that the "[PATCH 1/1]" bears an important information, >>> which is not present in "[PATCH]": this patch series contains only one >>> patch. >>> >>> IOW I do not like your patch: too much DWIDNS (Do What I Did NOT Say) for >>> me. >> How about the contrary ? > > Still DWIDNSAA. > Every piece of DWIM can be translated as "do what I didn't say". If you had to say it, it wouldn't be DWIM after all. -- Andreas Ericsson andreas.ericsson@op5.se OP5 AB www.op5.se Tel: +46 8-230225 Fax: +46 8-230231