From: "René Scharfe" <rene.scharfe@lsrfire.ath.cx>
To: git@vger.kernel.org
Cc: Paul Mackerras <paulus@samba.org>,
git@vger.kernel.org,
Johannes Schindelin <Johannes.Schindelin@gmx.de>
Subject: Re: Why is --pretty=format: so slow?
Date: Sun, 04 Nov 2007 11:31:10 +0100 [thread overview]
Message-ID: <472D9F6E.8070609@lsrfire.ath.cx> (raw)
In-Reply-To: <7vmytuvdvq.fsf@gitster.siamese.dyndns.org>
Junio C Hamano schrieb:
> Paul Mackerras <paulus@samba.org> writes:
>
>> Strace seems to indicate that git log is doing at least one sequence
>> of open, fstat64, fcntl64, getdents64 and close for each line of
>> output in the --pretty=format: cases, but not in the other cases.
>
> I bet that is coming from doing find_unique_abbrev() to fill
> fields %h, %t and %p, even when the output format does not ask
> for any of them.
>
> Dscho, can we stop calling find_unique_abbrev() unconditionally
> before being asked?
Incidentally, I'm finishing a patch series to add git-describe style
placeholders. It needs such an optimization even more badly (and has
it). Speeding up other slow placeholder expansions falls out quite
naturally. Please wait just a few minutes..
René
next prev parent reply other threads:[~2007-11-04 10:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-04 3:42 Why is --pretty=format: so slow? Paul Mackerras
2007-11-04 4:22 ` Junio C Hamano
2007-11-04 10:31 ` René Scharfe [this message]
2007-11-04 11:48 ` Junio C Hamano
2007-11-04 13:53 ` René Scharfe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=472D9F6E.8070609@lsrfire.ath.cx \
--to=rene.scharfe@lsrfire.ath.cx \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).