From: Johannes Sixt <j.sixt@viscovery.net>
To: Pierre Habouzit <madcoder@debian.org>
Cc: "Johannes Schindelin" <Johannes.Schindelin@gmx.de>,
"Björn Steinbrink" <B.Steinbrink@gmx.de>,
"Kristian Høgsberg" <krh@redhat.com>,
"Junio C Hamano" <gitster@pobox.com>,
git@vger.kernel.org
Subject: Re: [PATCH 4/4] Implement git commit and status as a builtin commands.
Date: Tue, 06 Nov 2007 10:18:02 +0100 [thread overview]
Message-ID: <4730314A.9010403@viscovery.net> (raw)
In-Reply-To: <20071106091222.GE4435@artemis.corp>
Pierre Habouzit schrieb:
> Btw, I'm starting to work slowly on the diff_opt_parse conversion to the
> macro we discussed, and the need for new option parsing callbacks
> arised, and I've created a:
>
> parse_opt_mask_{or,and,xor} commands that you declare this way:
>
> OPT_MASK_OR('a', "all", &mode, "...", MASK_ALL),
> OPT_MASK_OR('i', "interactive", &mode, "...", MASK_INTERACTIVE),
> ...
>
> And if you chose MASK_ALL/INTERACTIVE/.. to be single bits,
>
> if (!!all + !!interactive ... > 1)
>
> becomes[0]:
>
> if (mode & (mode - 1)) {
>
> }
This goes too far, IMHO. That's unnecessary cleverness/microoptimization at
the expense of readability.
-- Hannes
next prev parent reply other threads:[~2007-11-06 9:18 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-02 15:33 [PATCH 1/4] Add testcase for ammending and fixing author in git commit Kristian Høgsberg
2007-11-02 15:33 ` [PATCH 2/4] Remove unecessary hard-coding of EDITOR=':' VISUAL=':' in some test suites Kristian Høgsberg
2007-11-02 15:33 ` [PATCH 3/4] Export launch_editor() and make it accept ':' as a no-op editor Kristian Høgsberg
2007-11-02 15:33 ` [PATCH 4/4] Implement git commit and status as a builtin commands Kristian Høgsberg
2007-11-03 13:56 ` Johannes Schindelin
2007-11-08 16:01 ` Kristian Høgsberg
2007-11-03 15:06 ` Björn Steinbrink
2007-11-05 18:57 ` Kristian Høgsberg
2007-11-05 19:23 ` Björn Steinbrink
2007-11-05 23:18 ` Johannes Schindelin
2007-11-06 6:59 ` Björn Steinbrink
2007-11-06 16:46 ` Kristian Høgsberg
2007-11-06 17:08 ` Björn Steinbrink
2007-11-06 9:12 ` Pierre Habouzit
2007-11-06 9:18 ` Johannes Sixt [this message]
2007-11-06 9:26 ` Pierre Habouzit
2007-11-06 9:47 ` Andreas Ericsson
2007-11-06 16:42 ` Kristian Høgsberg
2007-11-02 15:46 ` [PATCH 3/4] Export launch_editor() and make it accept ':' as a no-op editor Andreas Ericsson
2007-11-02 16:16 ` Kristian Høgsberg
2007-11-02 20:09 ` [PATCH 2/4] Remove unecessary hard-coding of EDITOR=':' VISUAL=':' in some test suites Junio C Hamano
2007-11-02 20:07 ` [PATCH 1/4] Add testcase for ammending and fixing author in git commit Junio C Hamano
2007-11-02 21:13 ` Kristian Høgsberg
2007-11-02 22:33 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4730314A.9010403@viscovery.net \
--to=j.sixt@viscovery.net \
--cc=B.Steinbrink@gmx.de \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=krh@redhat.com \
--cc=madcoder@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).