From: Johannes Sixt <j.sixt@viscovery.net>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: git@vger.kernel.org, krh@redhat.com, gitster@pobox.com
Subject: Re: [PATCH 2/3] launch_editor(): read the file, even when EDITOR=:
Date: Thu, 08 Nov 2007 13:33:38 +0100 [thread overview]
Message-ID: <47330222.7000206@viscovery.net> (raw)
In-Reply-To: <Pine.LNX.4.64.0711081215360.4362@racer.site>
Johannes Schindelin schrieb:
> + struct child_process child;
> + memset(&child, 0, sizeof(child));
> + child.argv = args;
> + args[0] = editor;
> + args[1] = path;
> + args[2] = NULL;
>
> + if (run_command(&child))
You can shorten this to
const char *args[] = { editor, path, NULL };
if (run_command_v_opt(args, 0))
(and possibly remove 'args' that is in the surrounding block).
-- Hannes
next prev parent reply other threads:[~2007-11-08 12:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-08 12:14 [PATCH 0/3] builtin-commit fixes Johannes Schindelin
2007-11-08 12:15 ` [PATCH 1/3] builtin-commit: fix reflog message generation Johannes Schindelin
2007-11-08 12:15 ` [PATCH 2/3] launch_editor(): read the file, even when EDITOR=: Johannes Schindelin
2007-11-08 12:33 ` Johannes Sixt [this message]
2007-11-08 14:06 ` [PATCH REPLACING " Johannes Schindelin
2007-11-08 12:16 ` [PATCH 3/3] builtin-commit: fix author date with --amend --author=<author> Johannes Schindelin
2007-11-08 14:14 ` [PATCH 4/3] t3700: avoid racy git situation Johannes Schindelin
2007-11-08 14:34 ` Johannes Sixt
2007-11-08 15:16 ` Johannes Schindelin
2007-11-08 15:27 ` Kristian Høgsberg
2007-11-08 15:45 ` Johannes Sixt
2007-11-08 20:42 ` Junio C Hamano
2007-11-09 3:00 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47330222.7000206@viscovery.net \
--to=j.sixt@viscovery.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=krh@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).