From: Johannes Sixt <j.sixt@viscovery.net>
To: Benoit Sigoure <tsuna@lrde.epita.fr>
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Junio C Hamano <gitster@pobox.com>,
Jonas Fonseca <fonseca@diku.dk>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: [BUG] git-rebase fails when a commit message contains a diff
Date: Fri, 09 Nov 2007 09:57:34 +0100 [thread overview]
Message-ID: <473420FE.7010807@viscovery.net> (raw)
In-Reply-To: <6FCE17E3-9FAA-4676-B12A-369B31743DA6@lrde.epita.fr>
Benoit Sigoure schrieb:
> Off topic question: why do you guys always do this instead of doing,
> say, this:
>
> INTERACTIVE=false
>
> case $1 in
> --interactive|-i)
> INTERACTIVE=:
> ... ;;
> esac
> if $INTERACTIVE; then
> git_editor "$TODO" || die ...
> fi
Because in some shells 'false' is not a built-in.
But then this might do it without the extra process:
INTERACTIVE="! :" # false
case $1 in
--interactive|-i)
INTERACTIVE=:
... ;;
esac
if $INTERACTIVE; then
git_editor "$TODO" || die ...
fi
-- Hannes
next prev parent reply other threads:[~2007-11-09 8:58 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-09 1:12 [BUG] git-rebase fails when a commit message contains a diff Jonas Fonseca
2007-11-09 1:39 ` Junio C Hamano
2007-11-09 1:51 ` Junio C Hamano
2007-11-09 2:18 ` Junio C Hamano
2007-11-09 2:28 ` Johannes Schindelin
2007-11-09 2:37 ` Junio C Hamano
2007-11-09 14:19 ` Johannes Schindelin
2007-11-11 22:31 ` Björn Steinbrink
2007-11-09 7:57 ` Benoit Sigoure
2007-11-09 8:57 ` Johannes Sixt [this message]
2007-11-09 9:05 ` Ralf Wildenhues
2007-11-09 9:07 ` Benoit Sigoure
2007-11-09 13:20 ` Johannes Schindelin
2007-11-09 10:29 ` Andreas Ericsson
2007-11-09 7:03 ` Steffen Prohaska
2007-11-09 14:18 ` Johannes Schindelin
2007-11-09 14:29 ` Steffen Prohaska
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=473420FE.7010807@viscovery.net \
--to=j.sixt@viscovery.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=fonseca@diku.dk \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=tsuna@lrde.epita.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).