From: Andreas Ericsson <ae@op5.se>
To: Steffen Prohaska <prohaska@zib.de>
Cc: git@vger.kernel.org, Steffen Prohaska <gitster@pobox.com>
Subject: Re: [PATCH 3/6] push: support pushing HEAD to real branch name
Date: Sun, 11 Nov 2007 15:17:03 +0100 [thread overview]
Message-ID: <47370EDF.3090907@op5.se> (raw)
In-Reply-To: <11947897083159-git-send-email-prohaska@zib.de>
Steffen Prohaska wrote:
> diff --git a/builtin-push.c b/builtin-push.c
> index 6d1da07..a99ba0c 100644
> --- a/builtin-push.c
> +++ b/builtin-push.c
> @@ -44,6 +44,15 @@ static void set_refspecs(const char **refs, int nr)
> strcat(tag, refs[i]);
> ref = tag;
> }
> + if (!strcmp("HEAD", ref)) {
> + unsigned char sha1_dummy[20];
> + ref = resolve_ref(ref, sha1_dummy, 1, NULL);
> + if (!ref)
> + die("HEAD cannot be resolved.");
> + if (strncmp(ref, "refs/heads/", 11))
Why not prefixcmp(ref, "refs/heads/")?
--
Andreas Ericsson andreas.ericsson@op5.se
OP5 AB www.op5.se
Tel: +46 8-230225 Fax: +46 8-230231
next prev parent reply other threads:[~2007-11-11 14:17 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-11 14:01 [REPLACEMENT PATCH 0/6] improve refspec handling in push, refactor matching in fetch Steffen Prohaska
2007-11-11 14:01 ` [PATCH 1/6] push: mention --verbose option in documentation Steffen Prohaska
2007-11-11 14:01 ` [PATCH 2/6] push: teach push to pass --verbose option to transport layer Steffen Prohaska
2007-11-11 14:01 ` [PATCH 3/6] push: support pushing HEAD to real branch name Steffen Prohaska
2007-11-11 14:01 ` [PATCH 4/6] add ref_abbrev_matches_full_with_rules() Steffen Prohaska
2007-11-11 14:01 ` [PATCH 5/6] push: use same rules as git-rev-parse to resolve refspecs Steffen Prohaska
2007-11-11 14:01 ` [PATCH 6/6] refactor fetch's ref matching to use ref_abbrev_matches_full_with_rules() Steffen Prohaska
2007-11-11 14:55 ` Jakub Narebski
2007-11-11 17:31 ` Steffen Prohaska
2007-11-12 19:51 ` [PATCH 5/6] push: use same rules as git-rev-parse to resolve refspecs Junio C Hamano
2007-11-12 20:48 ` Steffen Prohaska
2007-11-12 19:51 ` [PATCH 4/6] add ref_abbrev_matches_full_with_rules() Junio C Hamano
2007-11-12 20:51 ` Steffen Prohaska
2007-11-11 14:17 ` Andreas Ericsson [this message]
2007-11-11 14:35 ` [REPLACEMENT PATCH 3/6] push: support pushing HEAD to real branch name Steffen Prohaska
2007-11-11 14:10 ` [PATCH 1/6] push: mention --verbose option in documentation Steffen Prohaska
2007-11-11 14:14 ` Steffen Prohaska
2007-11-11 19:39 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47370EDF.3090907@op5.se \
--to=ae@op5.se \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=prohaska@zib.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).