From: Johannes Sixt <j.sixt@viscovery.net>
To: Pierre Habouzit <madcoder@debian.org>
Cc: Junio C Hamano <gitster@pobox.com>,
Git Mailing List <git@vger.kernel.org>,
Shawn Bohrer <shawn.bohrer@gmail.com>
Subject: Re: [PATCH] git-clean: Fix error message if clean.requireForce is not set.
Date: Mon, 12 Nov 2007 09:41:03 +0100 [thread overview]
Message-ID: <4738119F.2030901@viscovery.net> (raw)
In-Reply-To: <20071112083352.GA20482@artemis.corp>
Pierre Habouzit schrieb:
> On Mon, Nov 12, 2007 at 08:27:35AM +0000, Johannes Sixt wrote:
>> It was distracting to see this error message:
>>
>> clean.requireForce set and -n or -f not given; refusing to clean
>>
>> even though clean.requireForce was not set at all. This patch
>> distinguishes
>> the cases and gives a different message depending on whether the
>> configuration variable is not set or set to true.
>
> Note that your patch won't apply to next as is :)
You mean because of the builtinification of git-clean? I was hoping that
Shawn (Bohrer) is listening and will update his patch. ;) It has the same
problem.
-- Hannes
next prev parent reply other threads:[~2007-11-12 8:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-12 8:27 [PATCH] git-clean: Fix error message if clean.requireForce is not set Johannes Sixt
2007-11-12 8:33 ` Pierre Habouzit
2007-11-12 8:41 ` Johannes Sixt [this message]
2007-11-12 12:24 ` Pierre Habouzit
2007-11-13 5:11 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4738119F.2030901@viscovery.net \
--to=j.sixt@viscovery.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=madcoder@debian.org \
--cc=shawn.bohrer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).