git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Sixt <j.sixt@viscovery.net>
To: Ping Yin <pkufranky@gmail.com>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH] status&commit: Teach them to show submodule commit summary
Date: Mon, 12 Nov 2007 16:59:11 +0100	[thread overview]
Message-ID: <4738784F.7010106@viscovery.net> (raw)
In-Reply-To: <1194877277-31777-1-git-send-email-pkufranky@gmail.com>

Ping Yin schrieb:
> git status/commit just treats submodules as ordinary files when reporting status
> changes. However, one may also wonder how submodules change (the commits).
> 
> This commit teaches git status/commit to additionally show commit summary of
> user-cared (i.e. checked out) modified submodules since HEAD (or HEAD^ if
> --amend option is on). For submodules deleted or initially added, commit summary
> are not shown.

In general, I like the idea (as I've already pointed out).

But at this time git-commit is about to be made a builtin, and since your 
implementation contains a lot of non-portable constructs ($'', >&) and a new 
dependency on awk (and, hence, has little chances of being accepted), I 
suggest that you stay tuned, and implement this in the forth-coming 
builtin-commit.c.

> A configuration variable 'submodule.status' is used to turn this summary
> behaviour on or off (default off). Also --submodule and --no-submodule options
> are added.

There is already 'status.color', I suggest the configuration to become 
'status.submoduleSummary'.

-- Hannes

  parent reply	other threads:[~2007-11-12 15:59 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-10 19:27 [PATCH] status&commit: Teach them to show commits of modified submodules Ping Yin
2007-11-10 19:55 ` Sven Verdoolaege
2007-11-10 20:00   ` Sven Verdoolaege
2007-11-11  5:30   ` Yin Ping
2007-11-10 21:14 ` Junio C Hamano
2007-11-11  6:18   ` Yin Ping
2007-11-11 20:34     ` Junio C Hamano
2007-11-12  5:38       ` Ping Yin
2007-11-12  7:26       ` Johannes Sixt
2007-11-12  9:51         ` Johannes Schindelin
2007-11-12 22:39           ` Junio C Hamano
2007-11-12  8:40       ` Johan Herland
2007-11-12 10:03   ` Johannes Sixt
2007-11-12 14:21     ` [PATCH] status&commit: Teach them to show submodule commit summary Ping Yin
2007-11-12 14:46       ` Ralf Wildenhues
2007-11-12 15:17         ` Ping Yin
2007-11-12 16:53           ` Brian Gernhardt
2007-11-12 15:37       ` Jakub Narebski
2007-11-12 15:46         ` Ping Yin
2007-11-12 15:59       ` Johannes Sixt [this message]
2007-11-12 16:12         ` Jakub Narebski
2007-11-12 16:42           ` Ping Yin
2007-11-12 16:13         ` Johannes Schindelin
2007-11-12 16:39           ` Ping Yin
2007-11-12 16:51             ` Johannes Sixt
2007-11-12 16:35         ` Ping Yin
2007-11-12 16:45           ` Johannes Sixt
2007-11-12 17:47             ` Lars Hjemli
2007-11-15 16:49               ` Ping Yin
2007-11-11  0:07 ` [PATCH] status&commit: Teach them to show commits of modified submodules Lars Hjemli
2007-11-11  6:24   ` Yin Ping
2007-11-11  8:27     ` Lars Hjemli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4738784F.7010106@viscovery.net \
    --to=j.sixt@viscovery.net \
    --cc=git@vger.kernel.org \
    --cc=pkufranky@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).