From: Dan Zwell <dzwell@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Jeff King <peff@peff.net>,
git@vger.kernel.org, Jakub Narebski <jnareb@gmail.com>
Subject: Re: [PATCH] git-config --get-color: get configured color
Date: Wed, 28 Nov 2007 01:58:59 -0600 [thread overview]
Message-ID: <474D1FC3.50108@zwell.net> (raw)
In-Reply-To: <7vir3mal9u.fsf_-_@gitster.siamese.dyndns.org>
Junio C Hamano wrote:
> +--get-color name default::
> +
> + Find the color configured for `name` (e.g. `color.diff.new`) and
> + output it as the ANSI color escape sequence to the standard
> + output. The optional `default` parameter is used if the
> + configuration for `name` is missing.
Perhaps you could mention here that the second parameter is a normal
string, not an ansi code? Just adding 'for example, "blue"' would
probably help.
> +RESET==$(git config --get-color "" "reset")
This is a typo, no?
+RESET=$(git config --get-color "" "reset")
Dan
prev parent reply other threads:[~2007-11-28 11:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-23 18:04 [PATCH] Add config_int() method to the Git perl module Jakub Narebski
2007-11-23 19:59 ` Junio C Hamano
2007-11-23 20:57 ` Wincent Colaiuta
2007-11-24 11:48 ` Jeff King
2007-11-28 7:20 ` [PATCH] git-config --get-color: get configured color Junio C Hamano
2007-11-28 7:58 ` Dan Zwell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=474D1FC3.50108@zwell.net \
--to=dzwell@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jnareb@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).