From: Johannes Sixt <j.sixt@viscovery.net>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Wincent Colaiuta <win@wincent.com>,
Junio C Hamano <gitster@pobox.com>,
Benoit Sigoure <tsuna@lrde.epita.fr>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH] Replace instances of export VAR=VAL with VAR=VAL; export VAR
Date: Wed, 28 Nov 2007 15:21:10 +0100 [thread overview]
Message-ID: <474D7956.8050401@viscovery.net> (raw)
In-Reply-To: <Pine.LNX.4.64.0711281355460.27959@racer.site>
Johannes Schindelin schrieb:
> - s/.*/export GIT_'$uid'_NAME='\''&'\''/p
> + s/.*/GIT_'$uid'_NAME='\''&'\''\nexport GIT_'$uid'_NAME/p
Recently there was a report that \n in the substitution side of s/// is not
supported by all seds :-(
> - export GIT_AUTHOR_NAME=$(sed -ne 's/Author: //p' "$tmp_info")
> - export GIT_AUTHOR_EMAIL=$(sed -ne 's/Email: //p' "$tmp_info")
> + GIT_AUTHOR_NAME=$(sed -ne 's/Author: //p' "$tmp_info")
> + GIT_AUTHOR_EMAIL=$(sed -ne 's/Email: //p' "$tmp_info")
> + export GIT_AUTHOR_NAME GIT_AUTHOR_EMAIL
This even fixes a bug: ash supports export VAR=VAL, but *does* word-split
VAL if it is not quoted.
-- Hannes
next prev parent reply other threads:[~2007-11-28 14:21 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-26 9:02 Rebase/cherry-picking idea Wincent Colaiuta
2007-11-26 9:32 ` Benoit Sigoure
2007-11-26 11:27 ` Wincent Colaiuta
2007-11-26 12:34 ` Wincent Colaiuta
2007-11-26 12:39 ` Benoit Sigoure
2007-11-26 12:51 ` Johannes Sixt
2007-11-26 13:15 ` Wincent Colaiuta
2007-11-26 13:41 ` Johannes Schindelin
2007-11-26 13:55 ` Wincent Colaiuta
2007-11-28 8:06 ` Junio C Hamano
2007-11-28 8:52 ` Wincent Colaiuta
2007-11-28 9:47 ` Junio C Hamano
2007-11-28 10:04 ` Wincent Colaiuta
2007-11-28 13:57 ` [PATCH] Replace instances of export VAR=VAL with VAR=VAL; export VAR Johannes Schindelin
2007-11-28 14:09 ` David Kastrup
2007-11-28 14:19 ` Nguyen Thai Ngoc Duy
2007-11-28 14:24 ` David Kastrup
2007-11-28 14:27 ` Nguyen Thai Ngoc Duy
2007-11-28 14:36 ` Johannes Schindelin
2007-11-28 14:27 ` Johannes Schindelin
2007-11-28 14:21 ` Johannes Sixt [this message]
2007-11-28 14:29 ` Johannes Schindelin
2007-11-28 14:39 ` Johannes Sixt
2007-11-28 15:56 ` [PATCH v2] " Johannes Schindelin
2007-11-28 16:03 ` David Kastrup
2007-11-28 22:46 ` Junio C Hamano
2007-11-28 22:53 ` David Kastrup
2007-11-28 23:02 ` Jeff King
2007-11-28 23:10 ` David Kastrup
2007-11-29 7:39 ` Johannes Sixt
2007-11-29 10:17 ` David Kastrup
2007-11-28 23:05 ` Johannes Schindelin
2007-11-28 18:49 ` [PATCH] " Junio C Hamano
2007-11-28 19:03 ` Johannes Schindelin
2007-11-28 22:48 ` Junio C Hamano
2007-11-28 23:08 ` Johannes Schindelin
2007-11-28 14:41 ` David Kastrup
2007-11-28 18:44 ` Rebase/cherry-picking idea Junio C Hamano
2007-11-26 17:26 ` Junio C Hamano
2007-11-26 19:12 ` Marco Costalba
2007-11-27 1:08 ` Shawn O. Pearce
2007-11-27 1:25 ` Junio C Hamano
2007-11-26 13:26 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=474D7956.8050401@viscovery.net \
--to=j.sixt@viscovery.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=tsuna@lrde.epita.fr \
--cc=win@wincent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).