git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andreas Ericsson <ae@op5.se>
To: "Karl Hasselström" <kha@treskal.com>
Cc: Jon Smirl <jonsmirl@gmail.com>, Git Mailing List <git@vger.kernel.org>
Subject: Re: StGit hooks
Date: Wed, 28 Nov 2007 18:06:36 +0100	[thread overview]
Message-ID: <474DA01C.8010901@op5.se> (raw)
In-Reply-To: <20071128154059.GA19302@diana.vm.bytemark.co.uk>

Karl Hasselström wrote:
> On 2007-11-28 15:58:13 +0100, Andreas Ericsson wrote:
> 
>> Jon Smirl wrote:
>>
>>> I would expect 'stg init' to switch the branch to using the stgit
>>> hooks and only those hooks. Branches that were not inited would
>>> continue to use the user hooks. I don't have any user hooks, but
>>> this is what I would expect to happen.
>> Obviously the stgit-installed hook will have to check if the branch
>> the user is operating on is managed by stgit before it prevents git
>> rebase (or whatever it's supposed to do).
> 
> Yes. The point is, hooks are per repository, not per branch. So
> there's no concept of "replacing the hooks for just this one branch".
> 

True, but there are ways of figuring out which branch you're on, using
the arguments passed to the hook.

The rebase hook (which is where this discussion started) gets the
branches passed to "git rebase" as arguments. Figuring out if either
of those branches are actually under stgit control shouldn't be overly
tricky for one so familiar with stgit as yourself.

-- 
Andreas Ericsson                   andreas.ericsson@op5.se
OP5 AB                             www.op5.se
Tel: +46 8-230225                  Fax: +46 8-230231

  reply	other threads:[~2007-11-28 17:07 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-27 22:17 stgit: lost all my patches again Jon Smirl
2007-11-27 22:24 ` Jakub Narebski
2007-11-27 23:12 ` Jon Smirl
2007-11-28  9:34   ` Karl Hasselström
2007-11-28 10:17     ` StGit hooks Karl Hasselström
2007-11-28 11:44       ` Andreas Ericsson
2007-11-28 12:19         ` Karl Hasselström
2007-11-28 13:14           ` Andreas Ericsson
2007-11-28 13:26             ` Karl Hasselström
2007-11-28 14:11               ` Andreas Ericsson
2007-11-28 14:53                 ` Jon Smirl
2007-11-28 14:58                   ` Andreas Ericsson
2007-11-28 15:40                     ` Karl Hasselström
2007-11-28 17:06                       ` Andreas Ericsson [this message]
2007-11-28 17:21                         ` Karl Hasselström
2007-11-28 19:31                           ` Junio C Hamano
2007-11-28 15:06     ` stgit: lost all my patches again Jon Smirl
2007-11-28 16:04       ` Karl Hasselström
2007-11-28 16:21         ` Jon Smirl
2007-11-28 16:41           ` Karl Hasselström
2007-11-28 16:58             ` Jon Smirl
2007-11-28 17:19               ` Karl Hasselström
2007-11-30  6:35             ` [StGit PATCH] Make "stg repair" help text more helpful Karl Hasselström
2007-11-28  0:37 ` stgit: lost all my patches again Junio C Hamano
2007-11-28  2:59   ` Jon Smirl
2007-11-28  6:32     ` Karl Hasselström

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=474DA01C.8010901@op5.se \
    --to=ae@op5.se \
    --cc=git@vger.kernel.org \
    --cc=jonsmirl@gmail.com \
    --cc=kha@treskal.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).