git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: A Large Angry SCM <gitzilla@gmail.com>
To: Jeff King <peff@peff.net>
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>,
	git@vger.kernel.org, gitster@pobox.com
Subject: Re: make test failure with latest master
Date: Mon, 03 Dec 2007 18:10:36 -0500	[thread overview]
Message-ID: <47548CEC.6010701@gmail.com> (raw)
In-Reply-To: <20071203015954.GB8322@coredump.intra.peff.net>

Jeff King wrote:
> On Sun, Dec 02, 2007 at 11:41:10PM +0000, Johannes Schindelin wrote:
> 
>>> Attached is the output of
>>>
>>> 	./t9600-cvsimport.sh --verbose >/tmp/9600_out.txt 2>&1
>>>
>> Unfortunately you attached the interesting part, so I cannot quote it 
>> here.  Seems that your cvsps does not understand the "-A" option.  So it 
>> looks like it is too old.

[Ignoring gitte's declaration that the core of git is dependent on CVS]

> Yes, the changelog indicates that -A was added in 2.1, and he is running
> 2.0rc1.
> 
> We can do something like this, though it feels a bit hack-ish and will
> need updated for new cvsps versions (a less lazy or more clever shell
> coder than me could do a nice >= version comparator).

The patch "fixes" the issue for me.

> -- >8 --
> t9600: require cvsps 2.1 to perform tests
> 
> git-cvsimport won't run at all with less than cvsps 2.1, because it
> lacks the -A flag. But there's no point in preventing people who have an
> old cvsps from running the full testsuite.
> 
> Signed-off-by: Jeff King <peff@peff.net>

Acked-by: A Large Angry SCM <gitzilla@gmail.com>

  parent reply	other threads:[~2007-12-03 23:11 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-02 12:29 make test failure with latest master A Large Angry SCM
2007-12-02 12:52 ` Jakub Narebski
2007-12-02 14:01   ` A Large Angry SCM
2007-12-02 16:34 ` Jeff King
2007-12-02 23:19   ` A Large Angry SCM
2007-12-02 23:41     ` Johannes Schindelin
2007-12-03  1:59       ` Jeff King
2007-12-03  7:33         ` Johannes Sixt
2007-12-03  7:35           ` Jeff King
2007-12-03 23:10         ` A Large Angry SCM [this message]
2007-12-03 23:21           ` Junio C Hamano
2007-12-03 23:25             ` A Large Angry SCM
2007-12-04  1:41             ` [PATCH] t9600: require cvsps 2.1 to perform tests Jeff King
2007-12-04  5:37               ` Junio C Hamano
2007-12-04 15:44                 ` Jeff King
2007-12-04 17:39                   ` Junio C Hamano
2007-12-05  1:02                     ` Jeff King
2007-12-05  5:44                       ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47548CEC.6010701@gmail.com \
    --to=gitzilla@gmail.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).