git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andreas Ericsson <ae@op5.se>
To: Pascal Obry <pascal.obry@wanadoo.fr>
Cc: Pascal Obry <pascal@obry.net>,
	Pascal Obry <pascal.obry@gmail.com>,
	git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] Set OLD_ICONV on Cygwin.
Date: Tue, 04 Dec 2007 14:43:23 +0100	[thread overview]
Message-ID: <4755597B.9050709@op5.se> (raw)
In-Reply-To: <21977191.137171196775591804.JavaMail.www@wwinf1621>

Pascal Obry wrote:
> Andreas Ericsson wrote:
>> Only one, insofar as I can see; You didn't CC Junio. He probably missed it.
> 
> Hum, I don't think this is a requirement. At least nothing is said about
> CCing Junio on the Git Web site.
> 

It's not a requirement, but he won't act on things he doesn't see, and CC'ing
him directly is the recommended way of getting his attention. Most people do
so for patches that aren't directly related to a sub-part of git primarily
maintained by someone else (Shawn O. Pearce for git-gui, Eric Wong for git-svn,
etc., etc.)

> Anyway, now Junio is CCed :)
> 

Nice. If my suspicions are correct and he missed your patch the first time
around, you should probably resend it though.

-- 
Andreas Ericsson                   andreas.ericsson@op5.se
OP5 AB                             www.op5.se
Tel: +46 8-230225                  Fax: +46 8-230231

  reply	other threads:[~2007-12-04 13:43 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-04 13:39 [PATCH] Set OLD_ICONV on Cygwin Pascal Obry
2007-12-04 13:43 ` Andreas Ericsson [this message]
2007-12-04 17:54   ` Junio C Hamano
2007-12-04 21:59     ` Junio C Hamano
2007-12-04 22:12       ` Pascal Obry
  -- strict thread matches above, loose matches on Subject: below --
2007-12-01  9:49 Pascal Obry
2007-12-03 18:49 ` Pascal Obry
2007-12-04  9:32   ` Andreas Ericsson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4755597B.9050709@op5.se \
    --to=ae@op5.se \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=pascal.obry@gmail.com \
    --cc=pascal.obry@wanadoo.fr \
    --cc=pascal@obry.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).