From: Johannes Sixt <j.sixt@viscovery.net>
To: Nicolas Pitre <nico@cam.org>
Cc: Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org, Jon Smirl <jonsmirl@gmail.com>
Subject: Re: [PATCH 2/2] pack-objects: fix threaded load balancing
Date: Tue, 11 Dec 2007 18:02:35 +0100 [thread overview]
Message-ID: <475EC2AB.60702@viscovery.net> (raw)
In-Reply-To: <alpine.LFD.0.99999.0712080000120.555@xanadu.home>
Nicolas Pitre schrieb:
> @@ -1612,10 +1620,10 @@ static void *threaded_find_deltas(void *arg)
> pthread_mutex_lock(&data_ready);
> pthread_mutex_unlock(&data_request);
>
> - if (!me->list_size)
> + if (!me->remaining)
> return NULL;
>
> - find_deltas(me->list, me->list_size,
> + find_deltas(me->list, &me->remaining,
> me->window, me->depth, me->processed);
> }
> }
This hunk caught my attention. &data_ready is locked, but not released in
this function.
Looking more closely at the code surrounding this hunk, it seems that the
lock is released in a *different* thread than the one that locked it. This
works on Linux, but is not portable. We will have to use condition variables
like every one else does in a producer-consumer-like scenario.
-- Hannes
next prev parent reply other threads:[~2007-12-11 17:03 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-08 5:03 [PATCH 2/2] pack-objects: fix threaded load balancing Nicolas Pitre
2007-12-08 9:18 ` Jeff King
2007-12-10 4:10 ` Jon Smirl
2007-12-10 4:30 ` Jon Smirl
2007-12-10 5:23 ` Jon Smirl
2007-12-10 5:59 ` Jon Smirl
2007-12-10 6:06 ` Jon Smirl
2007-12-10 6:19 ` Jon Smirl
2007-12-10 16:03 ` Nicolas Pitre
2007-12-10 16:14 ` Nicolas Pitre
2007-12-10 17:06 ` Jon Smirl
2007-12-10 18:21 ` Nicolas Pitre
2007-12-10 19:19 ` [PATCH] pack-objects: more threaded load balancing fix with often changed paths Nicolas Pitre
2007-12-11 17:02 ` Johannes Sixt [this message]
2007-12-11 17:28 ` [PATCH 2/2] pack-objects: fix threaded load balancing Nicolas Pitre
2007-12-13 7:15 ` Johannes Sixt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=475EC2AB.60702@viscovery.net \
--to=j.sixt@viscovery.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jonsmirl@gmail.com \
--cc=nico@cam.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).