Git development
 help / color / mirror / Atom feed
From: "René Scharfe" <l.s.r@web.de>
To: rsbecker@nexbridge.com
Cc: Beat Bolli <dev+git@drbeat.li>, git@vger.kernel.org
Subject: Re: Git 2.54.0-rc0 Breaks on OpenSSL 3.0
Date: Mon, 6 Apr 2026 09:07:22 +0200	[thread overview]
Message-ID: <47629c96-8764-45f1-b36d-d944d6282cb1@web.de> (raw)
In-Reply-To: <029f01dcc52f$2c8b8c70$85a2a550$@nexbridge.com>

On 4/5/26 9:05 PM, rsbecker@nexbridge.com wrote:
> Sadly, OpenSSL 3.0 is still out in the wild for those who have extended
> support contracts with OpenSSL. 

https://openssl-library.org/policies/releasestrat/index.html says
"Version 3.0 will be supported until 2026-09-07 (LTS)".

> The following errors happen using OpenSSL
> 3.0 when built with c99:
> 
> "/home/jenkinsbuild/.jenkins/workspace/Git_Pipeline/imap-send.c", line 274:
> error(252):
>           argument of type "const X509_NAME_ENTRY *" is incompatible with
>           parameter of type "X509_NAME_ENTRY *" (aka "struct
> X509_name_entry_st
>           *")

This line contains:

	    (cname = X509_NAME_ENTRY_get_data(cname_entry)) == NULL)

https://docs.openssl.org/3.0/man3/X509_NAME_ENTRY_get_object/ gives its
prototype as:

ASN1_STRING *X509_NAME_ENTRY_get_data(const X509_NAME_ENTRY *ne);

This has been matching the code since OpenSSL commit 9f5466b9b8
(Constify some X509_NAME, ASN1 printing code, 2016-07-07).  git describe
calls this commit OpenSSL_1_1_0-pre6-232-g9f5466b9b8.

>                                      ASN1_STRING_get0_data(cname),
> hostname);
>                                      ^
> "/home/jenkinsbuild/.jenkins/workspace/Git_Pipeline/imap-send.c", line 279:
> error(114):
>           identifier "ASN1_STRING_get0_data" is undefined

https://docs.openssl.org/3.0/man3/ASN1_STRING_length/ gives its
prototype as:

const unsigned char *ASN1_STRING_get0_data(const ASN1_STRING *x);

It was added by OpenSSL commit 17ebf85abd (Add ASN1_STRING_get0_data(),
deprecate ASN1_STRING_data()., 2016-08-16).  git describe calls this
commit OpenSSL_1_1_0-pre6-119-g17ebf85abd.

Are you sure you use OpenSSL 3.0?  The errors suggest it's a rather
older version (before 1.1.1).

René


  reply	other threads:[~2026-04-06  7:07 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-05 19:05 Git 2.54.0-rc0 Breaks on OpenSSL 3.0 rsbecker
2026-04-06  7:07 ` René Scharfe [this message]
2026-04-06 14:35   ` rsbecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47629c96-8764-45f1-b36d-d944d6282cb1@web.de \
    --to=l.s.r@web.de \
    --cc=dev+git@drbeat.li \
    --cc=git@vger.kernel.org \
    --cc=rsbecker@nexbridge.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox