From: Thomas Harning <harningt@gmail.com>
To: Steven Grimm <koreth@midwinter.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Allow commit (and tag) messages to be edited when $EDITOR has arguments
Date: Sat, 15 Dec 2007 20:41:53 -0500 [thread overview]
Message-ID: <47648261.1050505@gmail.com> (raw)
In-Reply-To: <20071216011201.GA10867@midwinter.com>
Steven Grimm wrote:
> Users who do EDITOR="/usr/bin/emacs -nw" or similar were left unable to
> edit commit messages once commit became a builtin, because the editor
> launch code assumed that $EDITOR was a single pathname.
>
I see one problem with this code... If you use quotes (single or
double) then this will break it. I suppose this isn't a major issue
usually, but if not fixed should be documented. One case that jumps out
of my head is an executable path with spaces (quite stupid-and-ugly, but
possible).
prev parent reply other threads:[~2007-12-16 1:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-16 1:12 [PATCH] Allow commit (and tag) messages to be edited when $EDITOR has arguments Steven Grimm
2007-12-16 1:41 ` Johannes Schindelin
2007-12-16 7:34 ` [PATCH v2] " Steven Grimm
2007-12-16 15:36 ` Johannes Schindelin
2007-12-16 1:41 ` Thomas Harning [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47648261.1050505@gmail.com \
--to=harningt@gmail.com \
--cc=git@vger.kernel.org \
--cc=koreth@midwinter.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).