From mboxrd@z Thu Jan 1 00:00:00 1970 From: Johannes Sixt Subject: Re: [PATCH] HP-UX does not have select.h Date: Tue, 18 Dec 2007 15:22:37 +0100 Message-ID: <4767D7AD.7030101@viscovery.net> References: <20071217192306.5da48540@pc09.procura.nl> <7v8x3t6nq1.fsf@gitster.siamese.dyndns.org> <20071217232259.0b41a3bf@pc09.procura.nl> <7vbq8o370k.fsf@gitster.siamese.dyndns.org> <476781C6.6050507@viscovery.net> <4767C105.8080607@viscovery.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Junio C Hamano , "H.Merijn Brand" , git@vger.kernel.org To: Johannes Schindelin X-From: git-owner@vger.kernel.org Tue Dec 18 15:23:19 2007 Return-path: Envelope-to: gcvg-git-2@gmane.org Received: from vger.kernel.org ([209.132.176.167]) by lo.gmane.org with esmtp (Exim 4.50) id 1J4dLk-0001Of-0W for gcvg-git-2@gmane.org; Tue, 18 Dec 2007 15:23:12 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755467AbXLROWl (ORCPT ); Tue, 18 Dec 2007 09:22:41 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755256AbXLROWl (ORCPT ); Tue, 18 Dec 2007 09:22:41 -0500 Received: from lilzmailso01.liwest.at ([212.33.55.23]:38933 "EHLO lilzmailso01.liwest.at" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753846AbXLROWk (ORCPT ); Tue, 18 Dec 2007 09:22:40 -0500 Received: from cm56-163-160.liwest.at ([86.56.163.160] helo=linz.eudaptics.com) by lilzmailso01.liwest.at with esmtpa (Exim 4.66) (envelope-from ) id 1J4dLR-00030j-FM; Tue, 18 Dec 2007 15:22:53 +0100 Received: from [127.0.0.1] (J6T.linz.viscovery [192.168.1.42]) by linz.eudaptics.com (Postfix) with ESMTP id 3953154D; Tue, 18 Dec 2007 15:22:37 +0100 (CET) User-Agent: Thunderbird 2.0.0.6 (Windows/20070728) In-Reply-To: X-Enigmail-Version: 0.95.5 X-Spam-Score: 1.7 (+) X-Spam-Report: ALL_TRUSTED=-1.8, BAYES_99=3.5 Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: Johannes Schindelin schrieb: > On Tue, 18 Dec 2007, Johannes Sixt wrote: >> Johannes Schindelin schrieb: >>> I'd be cautious about using poll(). AFAIK MacOSX 10.2.8 does not have >>> poll(), and IIRC I had problems finding it in MinGW, too. I know, we >>> use it in daemon, upload-archive and upload-pack, but these are not >>> typically functions performed by a client, so I would not know if it >>> worked on my (now-dead) iBook, or on msysGit. >> So what? If we use poll() already in daemon, upload-archive and >> upload-pack, and no MacOSX 10.2.8 user has spoken up with a proposal for >> replacement, then yet another use won't raise a complaint, either. > > daemon, upload-archive and upload-pack are server-side functions, so they > are substantially less well tested. upload-pack is used for local fetches and, therefore, should be well-tested on all systems. >> And if it were a problem for msysGit, I wouldn't have suggested it ;) >> The particular use in pager.c would be inside #ifndef __MINGW32__ #endif >> anyway. > > We still did not integrate the 'daemon' branch of 4msysgit, correct? No, we didn't. -- Hannes