From: Andreas Ericsson <ae@op5.se>
To: Pascal Obry <pascal@obry.net>
Cc: Pascal Obry <pascal.obry@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH] Add format-patch option --no-name-prefix.
Date: Wed, 19 Dec 2007 09:55:20 +0100 [thread overview]
Message-ID: <4768DC78.9010304@op5.se> (raw)
In-Reply-To: <4767F145.3030109@obry.net>
Pascal Obry wrote:
> Andreas Ericsson a écrit :
>> Pascal Obry wrote:
>>> int thread = 0;
>>> + int no_name_prefix = 0;
>> Do we not need no double negations, yes?
>
> Not sure, looks clearer to use variable name corresponding to the option
> name to me...
>
Perhaps. We just had this discussion on the list where multiple people had
extended a negative-sounding option. Personally I find it hard to parse
and bug-prone to write (and edit) something like
if (!no_prefix)
add_the_prefix();",
but perhaps that's just me.
--
Andreas Ericsson andreas.ericsson@op5.se
OP5 AB www.op5.se
Tel: +46 8-230225 Fax: +46 8-230231
next prev parent reply other threads:[~2007-12-19 8:55 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-18 15:42 [PATCH] Add format-patch option --no-name-prefix Pascal Obry
2007-12-18 15:47 ` Pascal Obry
2007-12-18 15:54 ` Johannes Sixt
2007-12-18 15:59 ` Pascal Obry
2007-12-18 16:50 ` Linus Torvalds
2007-12-18 16:54 ` Pascal Obry
2007-12-18 17:06 ` Johannes Schindelin
2007-12-18 17:56 ` Pascal Obry
2007-12-18 18:56 ` [PATCH] Teach diff machinery to display other prefixes than "a/" and "b/" Johannes Schindelin
2007-12-18 19:03 ` Pascal Obry
2007-12-18 19:05 ` Linus Torvalds
2007-12-18 19:32 ` [PATCH v4] " Johannes Schindelin
2007-12-18 19:55 ` Linus Torvalds
2007-12-18 20:07 ` [PATCH] Add format-patch option --no-name-prefix Junio C Hamano
2007-12-18 16:03 ` Andreas Ericsson
2007-12-18 16:11 ` Pascal Obry
2007-12-19 8:55 ` Andreas Ericsson [this message]
2007-12-19 9:21 ` Johannes Sixt
2007-12-18 16:21 ` [PATCH] Teach diff machinery to display other prefixes than "a/" and "b/" Johannes Schindelin
2007-12-18 16:45 ` Pascal Obry
2007-12-18 16:58 ` Johannes Schindelin
2007-12-18 17:02 ` Matthieu Moy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4768DC78.9010304@op5.se \
--to=ae@op5.se \
--cc=git@vger.kernel.org \
--cc=pascal.obry@gmail.com \
--cc=pascal@obry.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).