git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sam Vilain <sam@vilain.net>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Junio Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: Retroactively change email signature? [resend]
Date: Sat, 05 Jan 2008 12:08:43 +1300	[thread overview]
Message-ID: <477EBC7B.2080606@vilain.net> (raw)
In-Reply-To: <477EBB92.605@vilain.net>

Sam Vilain wrote:
> Linus Torvalds wrote:
>> I don't care. If some commit refers to another commit that isn't its 
>> ancestor, then that is undefined *anyway*. 
>>
>> So the only case that really matters is when you refer to your own strict 
>> ancestor.
>>
>> This is one reason why it was so crazy that "git cherry-pick" used to have 
>> "-x" by default - appending the original SHA1 (which is generally *not* an 
>> ancestor) is meaningless and stupid.
> 
> Not stupid at all.  It gives you an easily clickable link to the
> previous version of the patch, which may be of interest, and is
> otherwise irretrievable information if the patch needed resolving.

footnote: of course it is entirely meaningless if the referred SHA1 is
not published anywhere, so I agree with the cherry-pick default setting.

Sam.

      reply	other threads:[~2008-01-04 23:08 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-02 20:37 Retroactively change email signature? Stephen Sinclair
2008-01-02 21:17 ` Jakub Narebski
2008-01-02 21:24 ` Linus Torvalds
2008-01-02 22:06   ` Stephen Sinclair
2008-01-03  0:53     ` David Brown
2008-01-03  5:52   ` Retroactively change email signature? [resend] Sam Vilain
2008-01-04 18:34     ` Linus Torvalds
2008-01-04 23:04       ` Sam Vilain
2008-01-04 23:08         ` Sam Vilain [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=477EBC7B.2080606@vilain.net \
    --to=sam@vilain.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).