From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sam Vilain Subject: Re: Retroactively change email signature? [resend] Date: Sat, 05 Jan 2008 12:08:43 +1300 Message-ID: <477EBC7B.2080606@vilain.net> References: <9b3e2dc20801021237v4d5d236fn3d2643502b9bb78f@mail.gmail.com> <477C7837.9000303@vilain.net> <477EBB92.605@vilain.net> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Junio Hamano , git@vger.kernel.org To: Linus Torvalds X-From: git-owner@vger.kernel.org Sat Jan 05 00:08:26 2008 Return-path: Envelope-to: gcvg-git-2@gmane.org Received: from vger.kernel.org ([209.132.176.167]) by lo.gmane.org with esmtp (Exim 4.50) id 1JAveL-0007cb-6A for gcvg-git-2@gmane.org; Sat, 05 Jan 2008 00:08:25 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754480AbYADXH7 (ORCPT ); Fri, 4 Jan 2008 18:07:59 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754434AbYADXH7 (ORCPT ); Fri, 4 Jan 2008 18:07:59 -0500 Received: from watts.utsl.gen.nz ([202.78.240.73]:35596 "EHLO mail.utsl.gen.nz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754338AbYADXH6 (ORCPT ); Fri, 4 Jan 2008 18:07:58 -0500 Received: by mail.utsl.gen.nz (Postfix, from userid 65534) id 6503821D13A; Sat, 5 Jan 2008 12:07:57 +1300 (NZDT) Received: from [192.168.69.104] (203-97-235-49.cable.telstraclear.net [203.97.235.49]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.utsl.gen.nz (Postfix) with ESMTP id DAD4E21D13A; Sat, 5 Jan 2008 12:07:53 +1300 (NZDT) User-Agent: Thunderbird 2.0.0.6 (X11/20071022) In-Reply-To: <477EBB92.605@vilain.net> X-Enigmail-Version: 0.95.0 X-Spam-Checker-Version: SpamAssassin 3.0.3 (2005-04-27) on mail.musashi.utsl.gen.nz X-Spam-Level: X-Spam-Status: No, score=-2.8 required=5.0 tests=ALL_TRUSTED autolearn=failed version=3.0.3 Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: Sam Vilain wrote: > Linus Torvalds wrote: >> I don't care. If some commit refers to another commit that isn't its >> ancestor, then that is undefined *anyway*. >> >> So the only case that really matters is when you refer to your own strict >> ancestor. >> >> This is one reason why it was so crazy that "git cherry-pick" used to have >> "-x" by default - appending the original SHA1 (which is generally *not* an >> ancestor) is meaningless and stupid. > > Not stupid at all. It gives you an easily clickable link to the > previous version of the patch, which may be of interest, and is > otherwise irretrievable information if the patch needed resolving. footnote: of course it is entirely meaningless if the referred SHA1 is not published anywhere, so I agree with the cherry-pick default setting. Sam.