From: Michael Stefaniuc <mstefani@redhat.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] git-am: Run git gc only once and not for every patch.
Date: Sat, 05 Jan 2008 17:23:49 +0100 [thread overview]
Message-ID: <477FAF15.6020202@redhat.com> (raw)
In-Reply-To: <7vve68ep78.fsf@gitster.siamese.dyndns.org>
Junio C Hamano wrote:
> Junio C Hamano <gitster@pobox.com> writes:
>
>> ...
>> I do not think moving "gc --auto" outside the loop hurts in
>> practice because you are not likely to be rebasing a truly huge
>> series every day, but cruft can accumulate during "git am" run
>> and the "gc --auto" inside loop was meant to clean them up. The
>> idea was taken from importers that run repack every once in a
>> while (e.g. cvsimport runs every 1k commits), but "gc --auto"
>> was designed to be much more lightweight than a full repack and
>> that was the reason it was placed in the loop without counting
>> "every N commits".
>
> Having said all that, I'll take your patch as-is except that I'd
Thanks.
> drop the later part of the commit log message that explains
> Wine's practice.
Yeah, sorry about that. That should have been outside of the commit
message anyway. But forgot about it as the Wine maintainer takes only
the subject as commit message.
bye
michael
prev parent reply other threads:[~2008-01-05 16:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-04 18:59 [PATCH] git-am: Run git gc only once and not for every patch Michael Stefaniuc
2008-01-04 19:38 ` Nicolas Pitre
2008-01-04 20:21 ` Michael Stefaniuc
2008-01-04 20:58 ` Nicolas Pitre
2008-01-04 20:38 ` Junio C Hamano
2008-01-04 21:08 ` Michael Stefaniuc
2008-01-04 22:00 ` Junio C Hamano
2008-01-05 6:55 ` Junio C Hamano
2008-01-05 16:23 ` Michael Stefaniuc [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=477FAF15.6020202@redhat.com \
--to=mstefani@redhat.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).