From: Michael Haggerty <mhagger@alum.mit.edu>
To: "brian m. carlson" <sandals@crustytoothpaste.net>, git@vger.kernel.org
Cc: Jeff King <peff@peff.net>
Subject: Re: [PATCH 00/17] object_id part 6
Date: Mon, 2 Jan 2017 16:37:14 +0100 [thread overview]
Message-ID: <4780c459-b40c-3b5c-e780-fd792a35ce8f@alum.mit.edu> (raw)
In-Reply-To: <20170101191847.564741-1-sandals@crustytoothpaste.net>
On 01/01/2017 08:18 PM, brian m. carlson wrote:
> This is another series in the continuing conversion to struct object_id.
>
> This series converts more of the builtin directory and some of the
> refs code to use struct object_id. Additionally, it implements an
> nth_packed_object_oid function which provides a struct object_id
> version of the nth_packed_object function.
>
> There is a small known conflict with next, but it can easily be fixed up.
I read through all of the patches, and sent a few comments. I didn't
notice any other problems.
Michael
prev parent reply other threads:[~2017-01-02 15:37 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-01 19:18 [PATCH 00/17] object_id part 6 brian m. carlson
2017-01-01 19:18 ` [PATCH 01/17] builtin/commit: convert to struct object_id brian m. carlson
2017-01-01 19:18 ` [PATCH 02/17] builtin/diff-tree: " brian m. carlson
2017-01-01 19:18 ` [PATCH 03/17] builtin/describe: " brian m. carlson
2017-01-01 19:18 ` [PATCH 04/17] builtin/fast-export: " brian m. carlson
2017-01-01 19:18 ` [PATCH 05/17] builtin/fmt-merge-message: " brian m. carlson
2017-01-01 19:18 ` [PATCH 06/17] builtin/grep: " brian m. carlson
2017-01-01 19:18 ` [PATCH 07/17] builtin/branch: " brian m. carlson
2017-01-01 19:18 ` [PATCH 08/17] builtin/clone: " brian m. carlson
2017-01-01 19:18 ` [PATCH 09/17] builtin/merge: " brian m. carlson
2017-01-02 14:34 ` Michael Haggerty
2017-01-01 19:18 ` [PATCH 10/17] Convert remaining callers of resolve_refdup to object_id brian m. carlson
2017-01-01 19:18 ` [PATCH 11/17] builtin/replace: convert to struct object_id brian m. carlson
2017-01-01 19:18 ` [PATCH 12/17] reflog-walk: convert struct reflog_info " brian m. carlson
2017-01-01 19:18 ` [PATCH 13/17] refs: convert each_reflog_ent_fn " brian m. carlson
2017-01-02 15:07 ` Michael Haggerty
[not found] ` <20170102191256.fjqsns3rgjyehzgp@genre.crustytoothpaste.net>
2017-01-02 23:30 ` Michael Haggerty
2017-01-03 1:32 ` Jeff King
2017-01-01 19:18 ` [PATCH 14/17] sha1_file: introduce an nth_packed_object_oid function brian m. carlson
2017-01-02 15:30 ` Michael Haggerty
2017-01-02 17:09 ` Jeff King
2017-01-02 18:18 ` Michael Haggerty
2017-01-02 18:22 ` Jeff King
2017-01-01 19:18 ` [PATCH 15/17] Convert object iteration callbacks to struct object_id brian m. carlson
2017-01-01 19:18 ` [PATCH 16/17] builtin/merge-base: convert " brian m. carlson
2017-01-01 19:18 ` [PATCH 17/17] wt-status: " brian m. carlson
2017-01-02 15:37 ` Michael Haggerty [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4780c459-b40c-3b5c-e780-fd792a35ce8f@alum.mit.edu \
--to=mhagger@alum.mit.edu \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).