From: Johannes Sixt <j.sixt@viscovery.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH 1/2] sideband.c: Use xmalloc() instead of variable-sized arrays.
Date: Wed, 09 Jan 2008 08:26:34 +0100 [thread overview]
Message-ID: <4784772A.1060704@viscovery.net> (raw)
In-Reply-To: <7v4pdotdtl.fsf@gitster.siamese.dyndns.org>
Junio C Hamano schrieb:
> Johannes Sixt <j.sixt@viscovery.net> writes:
>> @@ -19,7 +19,10 @@ int recv_sideband(const char *me, int in_stream, int out, int err)
>> {
>> unsigned pf = strlen(PREFIX);
>> unsigned sf = strlen(SUFFIX);
>> - char buf[pf + LARGE_PACKET_MAX + sf + 1];
>> + char *buf, *save;
>> +
>> + save = xmalloc(sf);
>> + buf = xmalloc(pf + LARGE_PACKET_MAX + sf + 1);
>
> I have to wonder if the malloc() overhead is small enough
> compared to the network bandwidth to make a two malloc-free
> pairs per packet a non-issue...
recv_sideband() is called _once_per_connection_ and not for each packet.
Hence, these two mallocs should not concern us.
-- Hannes
prev parent reply other threads:[~2008-01-09 7:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-08 16:24 [PATCH 1/2] sideband.c: Use xmalloc() instead of variable-sized arrays Johannes Sixt
2008-01-08 17:01 ` Nicolas Pitre
2008-01-09 7:34 ` Johannes Sixt
2008-01-09 7:53 ` Junio C Hamano
2008-01-09 8:06 ` Johannes Sixt
2008-01-09 19:14 ` Nicolas Pitre
2008-01-08 17:41 ` Junio C Hamano
2008-01-08 19:59 ` Nicolas Pitre
2008-01-08 20:13 ` Junio C Hamano
2008-01-08 20:44 ` Nicolas Pitre
2008-01-09 7:26 ` Johannes Sixt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4784772A.1060704@viscovery.net \
--to=j.sixt@viscovery.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).